<html><head></head><body>Hi,<br><br>I think there should be separate options for each affected module simply because there underlying logging systems use different classifications. We should not reduce this to a boolean.<br><br><div class="gmail_quote">Le 20 janvier 2020 09:14:49 GMT+02:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi,<br><br>Any news on this ? Where should we move it?<br><br>Regards,<br>--<br>Alexandre Janniaux<br>Videolabs<br><br>On Thu, Dec 12, 2019 at 11:10:08AM +0100, Alexandre Janniaux wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Hi,<br><br> On Thu, Dec 12, 2019 at 11:04:14AM +0100, Marvin Scholz wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> On 12 Dec 2019, at 10:01, Alexandre Janniaux wrote:<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">The `quiet' VLC variable is used although it is exposed only by other<br>non-mandatory modules. Rename it to avcodec/avformat-quiet so as to<br>prevent assertion on platform that won't ship with a module exposing a<br>quiet variable.<br></blockquote> Hi, thanks for the patch!<br><br> While this approach works to fix the issue and seems certainly like a<br> possible<br> solution to me, I think it would be more convenient to have just one `quiet`<br> variable and not a per-module one. So maybe the variable should be „owned“<br> by<br> the core instead?<br><br> Although it seems we already have several module-specific quiet options<br> so maybe we want to keep it that way even though to me it seems weird…<br></blockquote> That's a good question, about moving it to libvlc-modules.c<br> instead. I don't know, because it's quite alike the<br> fullscreen option or volume option. I've never used this and<br> don't really need it, but it was preventing vlc-ios 4.0 from<br> running videos with avcodec/avformat.<br><br> I'm fine with either what I did or moving it to<br> libvlc-modules.c.<br><br> Regards,<br> --<br> Alexandre Janniaux<br> Videolabs<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>