<html><head></head><body>Hi,<br><br>That won't change anything w.r.t. to id10t errors. Decoded parameters will still be confusing, until/unless they are removed completely (and I'd rather close bugs as invalid than conceal some meta).<br><br><div class="gmail_quote">Le 27 janvier 2020 16:17:31 GMT+02:00, Francois Cartegnie <fcvlcdev@free.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Because users can't get it. Too many invalid bugs.<hr> src/input/es_out.c | 47 +++++++++++++++++++++++++++++++++++-----------<br> 1 file changed, 36 insertions(+), 11 deletions(-)<br><br>diff --git a/src/input/es_out.c b/src/input/es_out.c<br>index 2a8dd6ce8d..df4bd89f84 100644<br>--- a/src/input/es_out.c<br>+++ b/src/input/es_out.c<br>@@ -3802,22 +3802,47 @@ static void EsOutUpdateInfo( es_out_t *out, es_out_id_t *es, const vlc_meta_t *p<br> case AUDIO_ES:<br> info_category_AddInfo( p_cat, _("Type"), _("Audio") );<br> <br>- if( fmt->audio.i_physical_channels )<br>+ if( p_fmt_es->audio.i_physical_channels )<br> info_category_AddInfo( p_cat, _("Channels"), "%s",<br>- vlc_gettext( aout_FormatPrintChannels( &fmt->audio ) ) );<br>+ vlc_gettext( aout_FormatPrintChannels( &p_fmt_es->audio ) ) );<br> <br>- if( fmt->audio.i_rate != 0 )<br>- {<br>+ if( p_fmt_es->audio.i_rate )<br> info_category_AddInfo( p_cat, _("Sample rate"), _("%u Hz"),<br>- fmt->audio.i_rate );<br>- }<br>+ p_fmt_es->audio.i_rate );<br> <br>- unsigned int i_bitspersample = fmt->audio.i_bitspersample;<br>- if( i_bitspersample == 0 )<br>- i_bitspersample = aout_BitsPerSample( fmt->i_codec );<br>- if( i_bitspersample != 0 )<br>+ unsigned int i_orgbps = p_fmt_es->audio.i_bitspersample;<br>+ if( i_orgbps == 0 )<br>+ i_orgbps = aout_BitsPerSample( p_fmt_es->i_codec );<br>+ if( i_orgbps != 0 )<br> info_category_AddInfo( p_cat, _("Bits per sample"), "%u",<br>- i_bitspersample );<br>+ i_orgbps );<br>+<br>+ if( fmt->audio.i_format &&<br>+ fmt->audio.i_format != p_fmt_es->i_codec )<br>+ {<br>+ psz_codec_description = vlc_fourcc_GetDescription( AUDIO_ES,<br>+ fmt->audio.i_format );<br>+ info_category_AddCodecInfo( p_cat, _("Decoded format"),<br>+ fmt->audio.i_format,<br>+ psz_codec_description );<br>+ }<br>+<br>+ if( fmt->audio.i_physical_channels &&<br>+ fmt->audio.i_physical_channels != p_fmt_es->audio.i_physical_channels )<br>+ info_category_AddInfo( p_cat, _("Decoded channels"), "%s",<br>+ vlc_gettext( aout_FormatPrintChannels( &fmt->audio ) ) );<br>+<br>+ if( fmt->audio.i_rate &&<br>+ fmt->audio.i_rate != p_fmt_es->audio.i_rate )<br>+ info_category_AddInfo( p_cat, _("Decoded sample rate"), _("%u Hz"),<br>+ fmt->audio.i_rate );<br>+<br>+ unsigned i_outbps = fmt->audio.i_bitspersample;<br>+ if( i_outbps == 0 )<br>+ i_outbps = aout_BitsPerSample( fmt->i_codec );<br>+ if( i_outbps != 0 && i_outbps != i_orgbps )<br>+ info_category_AddInfo( p_cat, _("Decoded bits per sample"), "%u",<br>+ i_outbps );<br> <br> if( fmt->i_bitrate != 0 )<br> {</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>