<html><head></head><body>Hi,<br><br>I don't understand what the question is here. Either we take the code base and coding conventions in a direction that this patch becomes valid, or we don't take this patch. You can't have it both ways, AFAICT.<br><br><div class="gmail_quote">Le 29 janvier 2020 09:41:09 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">What I would like is being able to use objres in all modules without asking myself if the owner will handle it.<br><br>So what do we do ?<br> - Should each modules owner handle the resource clearing themselves ? In that case, we need to expose objres API in VLC core (for submodules).<br> - Or apply this patch (+modifications mentioned by Steve)<br><br><br><br>On Mon, Jan 27, 2020, at 19:53, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le maanantaina 27. tammikuuta 2020, 17.08.47 EET Thomas Guillem a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On Mon, Jan 27, 2020, at 15:00, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Hi,<br><br>I don't think that we require an object to be deleted after a single<br>module probe though (unlike the kernel), or do we?<br></blockquote>No we don't require it, and nothing prevent to load/unload different kind of<br>module using one vlc_object.<br></blockquote>In any case, you can't bind more than one module per object at a time if <br>modules use object resources. But if you can bind multiple modules <br>consecutively, then clearing resources at deletion is inadequate, as it could <br>lead to temporary linear resource leak.<br><br>IIRC, the kernel explicitly forbids binding a driver and an object more than <br>once, so then cleaning up resources at object deletion is a legitimate <br>simplification. But it does not seem like it for VLC - or at least not so far.<br><br>-- <br>Реми Дёни-Курмон<br><a href="http://www.remlab.net/">http://www.remlab.net/</a><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>