<html><head></head><body>That older patch has a different problem that was already raised.<br><br><div class="gmail_quote">Le 30 janvier 2020 13:08:35 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-01-30 10:46, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">LIBATOMIC=-latomic is an artefact of GCC, not of rPI, and what function <br>need it depend on the target CPU, not the rPI either.<br></blockquote><br>So this patch should do<br><a href="https://patches.videolan.org/patch/25978/">https://patches.videolan.org/patch/25978/</a><br><br>It keeps -latomic globally if it's needed to get the atomics API.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 30 janvier 2020 10:07:02 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a <br>écrit :<br><br> We don't have a way to detect the target is a Raspberry so we enable it manually.<br><br> Only the libvlccore seems to need it for proper linkings. Modules don't need it.<hr> configure.ac | 4 ++++<br> src/Makefile.am | 2 +-<br> 2 files changed, 5 insertions(+), 1 deletion(-)<br><br> diff --git a/configure.ac b/configure.ac<br> index 69b09dfe3ac..45f95f64299 100644<br> --- a/configure.ac<br> +++ b/configure.ac<br> @@ -3655,6 +3655,7 @@ AM_CONDITIONAL([HAVE_KVA], [test "${have_kva}" = "yes"])<br> dnl<br> dnl MMAL plugin<br> dnl<br> +LIBATOMIC=""<br> AC_ARG_ENABLE([mmal],<br> AS_HELP_STRING([--enable-mmal],<br> [Multi-Media Abstraction Layer (MMAL) hardware plugin (default enable)]))<br> @@ -3665,6 +3666,8 @@ if test "${enable_mmal}" != "no"; then<br> AC_CHECK_HEADERS([interface/mmal/mmal.h],<br> [ AC_CHECK_LIB([bcm_host], [vc_tv_unregister_callback_full], [<br> have_mmal="yes"<br> + dnl we build for Raspberry which needs the latomic flag<br> + LIBATOMIC="-latomic"<br> VLC_ADD_PLUGIN([mmal])<br> VLC_ADD_LDFLAGS([mmal],[ -L/opt/vc/lib ])<br> VLC_ADD_CFLAGS([mmal],[ -isystem /opt/vc/include -isystem /opt/vc/include/interface/vcos/pthreads -isystem /opt/vc/include/interface/vmcs_host/linux ])<br> @@ -3680,6 +3683,7 @@ if test "${enable_mmal}" != "no"; then<br> VLC_RESTORE_FLAGS<br> fi<br> AM_CONDITIONAL([HAVE_MMAL], [test "${have_mmal}" = "yes"])<br> +AC_SUBST([LIBATOMIC])<br> <br> dnl<br> dnl Audio plugins<br> diff --git a/src/Makefile.am b/src/Makefile.am<br> index b6c59968370..4bf36cf3e85 100644<br> --- a/src/Makefile.am<br> +++ b/src/Makefile.am<br> @@ -393,7 +393,7 @@ libvlccore_la_SOURCES = \<br> libvlccore_la_LIBADD = $(LIBS_libvlccore) \<br> ../compat/libcompat.la \<br> $(LTLIBINTL) $(LTLIBICONV) \<br> - $(IDN_LIBS) $(SOCKET_LIBS) $(LIBRT) $(LIBDL) $(LIBM)<br> + $(IDN_LIBS) $(SOCKET_LIBS) $(LIBRT) $(LIBDL) $(LIBM) $(LIBATOMIC)<br> <br> if HAVE_WIN32<br> libvlccore_la_SOURCES += \<br><br><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>