<html><head></head><body>Hi,<br><br>You can't predict the future, but there is a real risk that a signed integer does not fit, whereas a pointer will always fit... This could use a union like vout_window_t with a stub pointer to reserve the space.<br><br><div class="gmail_quote">Le 5 février 2020 14:03:06 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-02-04 19:52, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le tiistaina 4. helmikuuta 2020, 17.25.58 EET Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> diff --git a/include/vlc/libvlc_media_player.h<br> b/include/vlc/libvlc_media_player.h index 70970f8c104..940059f044d 100644<br> --- a/include/vlc/libvlc_media_player.h<br> +++ b/include/vlc/libvlc_media_player.h<br> @@ -521,15 +521,29 @@ typedef bool (*libvlc_video_setup_cb)(void* opaque);<br> */<br> typedef void (*libvlc_video_cleanup_cb)(void* opaque);<br><br> +typedef struct<br> +{<br> + int surface_format; /** the rendering DXGI_FORMAT for \ref<br> libvlc_video_direct3d_engine_d3d11,<br> + D3DFORMAT<br> for \ref libvlc_video_direct3d_engine_d3d9, +<br> GL_RGBA or GL_RGB for \ref libvlc_video_engine_opengl and +<br> for \ref libvlc_video_engine_gles2 */<br></blockquote>How do we know that 'int' works for all rendering APIs?<br></blockquote><br>It does for all API's we support now.<br><br>If your question is about future API's (Vulkan, Metal, whatever) there's <br>no guarantee it's not needing a 512-byte structure. We can't predict the <br>future. But it's unlikely a surface format will use anything other than <br>an enum or a FourCC.<br><br>We may version the structures we read/write in the API so we can add <br>fields in the future if necessary. But IMO it's overkill.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>