<html><head></head><body>'inline' is useless outside headers for static functions. As already noted, I'd rather we make these two proper private functions of the core.<br><br><div class="gmail_quote">Le 10 février 2020 11:02:19 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">It's only used there and this way we can use the proper type matching the<br>storage.<hr> include/vlc_threads.h | 10 ----------<br> src/misc/threads.c | 10 ++++++++++<br> 2 files changed, 10 insertions(+), 10 deletions(-)<br><br>diff --git a/include/vlc_threads.h b/include/vlc_threads.h<br>index 2e85d63d6be..341ee97271e 100644<br>--- a/include/vlc_threads.h<br>+++ b/include/vlc_threads.h<br>@@ -1100,16 +1100,6 @@ static inline void vlc_cleanup_lock (void *lock)<br> }<br> #define mutex_cleanup_push( lock ) vlc_cleanup_push (vlc_cleanup_lock, lock)<br> <br>-static inline void vlc_cancel_addr_set(void *addr)<br>-{<br>- vlc_control_cancel(VLC_CANCEL_ADDR_SET, addr);<br>-}<br>-<br>-static inline void vlc_cancel_addr_clear(void *addr)<br>-{<br>- vlc_control_cancel(VLC_CANCEL_ADDR_CLEAR, addr);<br>-}<br>-<br> #ifdef __cplusplus<br> /**<br> * Helper C++ class to lock a mutex.<br>diff --git a/src/misc/threads.c b/src/misc/threads.c<br>index 501a17ac9b3..e6b993c4408 100644<br>--- a/src/misc/threads.c<br>+++ b/src/misc/threads.c<br>@@ -149,6 +149,16 @@ bool vlc_mutex_marked(const vlc_mutex_t *mutex)<br> #if defined(LIBVLC_NEED_SLEEP) || defined(LIBVLC_NEED_CONDVAR)<br> #include <stdatomic.h><br> <br>+static inline void vlc_cancel_addr_set(void *addr)<br>+{<br>+ vlc_control_cancel(VLC_CANCEL_ADDR_SET, addr);<br>+}<br>+<br>+static inline void vlc_cancel_addr_clear(void *addr)<br>+{<br>+ vlc_control_cancel(VLC_CANCEL_ADDR_CLEAR, addr);<br>+}<br>+<br> static void vlc_cancel_addr_prepare(void *addr)<br> {<br> /* Let thread subsystem on address to broadcast for cancellation */</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>