<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Tue, Feb 18, 2020, at 18:12, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>Hi,<br></div><div><br></div><div>I don't really get why we need a new context (1-2) if we have one layered output per source (3).<br></div></blockquote><div><br></div><div>The input_source_t is not exposed in CORE API.<br></div><div>OK, demux modules won't need to access this context/source, they will just need to pass it around, so they don't need to know the definition.<br></div><div><br></div><div>So yeah, I could pass the input_source_t instead, but I will need to add refcount support first (because timeshift).<br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div class="qt-gmail_quote"><div>Le 18 février 2020 18:11:16 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><pre class="qt-k9mail"><div>In order to be able to specify an es_out_t per input_source_t.<hr> src/input/input.c | 9 +++++----<br></div><div> 1 file changed, 5 insertions(+), 4 deletions(-)<br></div><div><br></div><div>diff --git a/src/input/input.c b/src/input/input.c<br></div><div>index 2dd0bf09821..c033cdaae91 100644<br></div><div>--- a/src/input/input.c<br></div><div>+++ b/src/input/input.c<br></div><div>@@ -2427,7 +2427,7 @@ InputStreamHandleAnchor( input_thread_t *p_input, input_source_t *source,<br></div><div> return VLC_SUCCESS;<br></div><div> }<br></div><div> <br></div><div>-static demux_t *InputDemuxNew( input_thread_t *p_input,<br></div><div>+static demux_t *InputDemuxNew( input_thread_t *p_input, es_out_t *p_es_out,<br></div><div> input_source_t *p_source, const char *url,<br></div><div> const char *psz_demux, const char *psz_anchor )<br></div><div> {<br></div><div>@@ -2435,7 +2435,7 @@ static demux_t *InputDemuxNew( input_thread_t *p_input,<br></div><div> vlc_object_t *obj = VLC_OBJECT(p_input);<br></div><div> <br></div><div> /* create the underlying access stream */<br></div><div>- stream_t *p_stream = stream_AccessNew( obj, p_input, priv->p_es_out,<br></div><div>+ stream_t *p_stream = stream_AccessNew( obj, p_input, p_es_out,<br></div><div> priv->b_preparsing, url );<br></div><div> if( p_stream == NULL )<br></div><div> return NULL;<br></div><div>@@ -2469,7 +2469,7 @@ static demux_t *InputDemuxNew( input_thread_t *p_input,<br></div><div> <br></div><div> /* create a regular demux with the access stream created */<br></div><div> demux_t *demux = demux_NewAdvanced( obj, p_input, psz_demux, url, p_stream,<br></div><div>- priv->p_es_out, priv->b_preparsing );<br></div><div>+ p_es_out, priv->b_preparsing );<br></div><div> if( demux != NULL )<br></div><div> return demux;<br></div><div> <br></div><div>@@ -2576,7 +2576,8 @@ static input_source_t *InputSourceNew( input_thread_t *p_input,<br></div><div> char *url;<br></div><div> if( likely(asprintf( &url, "%s://%s", psz_access, psz_path ) >= 0) )<br></div><div> {<br></div><div>- in->p_demux = InputDemuxNew( p_input, in, url, psz_demux, psz_anchor );<br></div><div>+ in->p_demux = InputDemuxNew( p_input, priv->p_es_out, in, url,<br></div><div>+ psz_demux, psz_anchor );<br></div><div> free( url );<br></div><div> }<br></div><div> else<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>