<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Tue, Feb 18, 2020, at 18:16, Rémi Denis-Courmont wrote:<br></div><blockquote id="qt" type="cite"><div>Hi,<br></div><div><br></div><div>Identification with a tuple of a (reference-counted) pointer and an ID seems like the worse of both worlds. It's not serial, but it's not a single value and its uniqueness depends on the demuxer.<br></div><div><br></div><div>Why can't we identify an ES by its ID pointer, which already exists (though it might be missing a reference count)??<br></div></blockquote><div><br></div><div>We can already identify an ES track by its ID pointer, yes it is refcounted and it is currently used by all intf/control modules.<br></div><div>I plan to do the same for LibVLC.<br></div><div><br></div><div>But anyway, we will always need to identify a track with a string for the following use case:<br></div><div><br></div><div> - Selecting a precise track via command line, with --video-track-id "video/1" or --sub-track-id "<a href="http://myfile.srt/sub/0">myfile.srt/sub/0</a>"<br></div><div> - Remembering the user track selection preference in a database, to restore the previous state later. Therefore the track id need to be a string or a int.<br></div><div><br></div><div>Indeed,<br></div><div>selecting a track via its ID pointer is 100% sure,<br></div><div>selecting a track via its string id is a little error prone (I would say more than 99% of success now).<br></div><div><br></div><div>The only 3 collision issues we could have now (once this set is merged):<br></div><div> - 2 sub slaves having the same name: In that case, the second source will have an other ID but it will now depend on slave addition order. cf. my comment on patch 04/18.<br></div><div> - Forged mkv/mp4/ts with tracks having the same track id<br></div><div> - ts adding a track, removing it, and adding an other track with the same ID<br></div><div><br></div><div>Collision will be expected (because you can never trust the input) but won't be critical. The only problems you will have is that your prefered track might be not saved on a second VLC run.<br></div><div><br></div><div>If we really don't want collision (for the last 2 cases), I can "-[0-9]" to my tracks ID having the same ID than previous ones (but then, it will depend on addition order).<br></div><div><br></div><div>Example: video/245 and video/245-0<br></div><div><br></div><blockquote id="qt" type="cite"><div><br></div><div class="qt-gmail_quote"><div>Le 18 février 2020 18:11:18 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-k9mail"><div>A specified program (group > 0) is identified by its group id and by its<br></div><div>context pointer. The default program (group = 0) can be used by more than one<br></div><div>contexts.<br></div><div><br></div><div>An ES track is now identified by its i_id and by its context pointer. In case<br></div><div>of automatic track ids, the id counter will be handled by each contexts (or<br></div><div>input source). This mean that the id counter starts at 0 for each new source.<br></div><div><br></div><div>A slave specifying its group won't be able to be played alongside the master<br></div><div>source by default (except if we play more than one programs at a time).<hr> src/input/es_out.c | 106 ++++++++++++++++++++++++++++++++-------------<br></div><div> 1 file changed, 75 insertions(+), 31 deletions(-)<br></div><div><br></div><div>diff --git a/src/input/es_out.c b/src/input/es_out.c<br></div><div>index 1c98d85add4..4ae27b63734 100644<br></div><div>--- a/src/input/es_out.c<br></div><div>+++ b/src/input/es_out.c<br></div><div>@@ -61,6 +61,9 @@<br></div><div> *****************************************************************************/<br></div><div> typedef struct<br></div><div> {<br></div><div>+ /* Program context */<br></div><div>+ es_out_ctx_t *ctx;<br></div><div>+<br></div><div> /* Program ID */<br></div><div> int i_id;<br></div><div> <br></div><div>@@ -98,6 +101,10 @@ struct es_out_id_t<br></div><div> /* weak reference, used by input_decoder_callbacks and vlc_clock_cbs */<br></div><div> es_out_t *out;<br></div><div> <br></div><div>+ /* Context used to create this ES. Equals to p_pgrm->ctx when not using a<br></div><div>+ * default program id. */<br></div><div>+ es_out_ctx_t *ctx;<br></div><div>+<br></div><div> /* ES ID */<br></div><div> es_out_pgrm_t *p_pgrm;<br></div><div> <br></div><div>@@ -165,6 +172,9 @@ typedef struct<br></div><div> {<br></div><div> input_thread_t *p_input;<br></div><div> <br></div><div>+ /* Main source context */<br></div><div>+ es_out_ctx_t *main_ctx;<br></div><div>+<br></div><div> /* */<br></div><div> vlc_mutex_t lock;<br></div><div> <br></div><div>@@ -481,6 +491,13 @@ es_out_t *input_EsOutNew( input_thread_t *p_input, float rate )<br></div><div> <br></div><div> p_sys->out.cbs = &es_out_cbs;<br></div><div> <br></div><div>+ p_sys->main_ctx = es_out_ctx_New(NULL);<br></div><div>+ if( !p_sys->main_ctx )<br></div><div>+ {<br></div><div>+ free( p_sys );<br></div><div>+ return NULL;<br></div><div>+ }<br></div><div>+<br></div><div> vlc_mutex_init( &p_sys->lock );<br></div><div> p_sys->p_input = p_input;<br></div><div> <br></div><div>@@ -578,6 +595,7 @@ static void EsRelease(es_out_id_t *es)<br></div><div> free(es->psz_language);<br></div><div> free(es->psz_language_code);<br></div><div> es_format_Clean(&es->fmt);<br></div><div>+ es_out_ctx_Release(es->ctx);<br></div><div> free(es);<br></div><div> }<br></div><div> }<br></div><div>@@ -600,6 +618,8 @@ static void EsOutDelete( es_out_t *out )<br></div><div> <br></div><div> vlc_mutex_destroy( &p_sys->lock );<br></div><div> <br></div><div>+ es_out_ctx_Release( p_sys->main_ctx );<br></div><div>+<br></div><div> free( p_sys );<br></div><div> }<br></div><div> <br></div><div>@@ -609,6 +629,7 @@ static void ProgramDelete( es_out_pgrm_t *p_pgrm )<br></div><div> vlc_clock_main_Delete( p_pgrm->p_main_clock );<br></div><div> if( p_pgrm->p_meta )<br></div><div> vlc_meta_Delete( p_pgrm->p_meta );<br></div><div>+ es_out_ctx_Release( p_pgrm->ctx );<br></div><div> <br></div><div> free( p_pgrm );<br></div><div> }<br></div><div>@@ -1245,10 +1266,11 @@ static void EsOutSendEsEvent(es_out_t *out, es_out_id_t *es, int action)<br></div><div> });<br></div><div> }<br></div><div> <br></div><div>-static bool EsOutIsProgramVisible( es_out_t *out, int i_group )<br></div><div>+static bool EsOutIsProgramVisible( es_out_t *out, es_out_ctx_t *ctx, int i_group )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div>- return p_sys->i_group_id == 0 || p_sys->i_group_id == i_group;<br></div><div>+ return p_sys->i_group_id == 0<br></div><div>+ || (p_sys->i_group_id == i_group && p_sys->p_pgrm->ctx == ctx);<br></div><div> }<br></div><div> <br></div><div> /* EsOutProgramSelect:<br></div><div>@@ -1333,7 +1355,7 @@ static void EsOutProgramSelect( es_out_t *out, es_out_pgrm_t *p_pgrm )<br></div><div> /* EsOutAddProgram:<br></div><div> * Add a program<br></div><div> */<br></div><div>-static es_out_pgrm_t *EsOutProgramAdd( es_out_t *out, int i_group )<br></div><div>+static es_out_pgrm_t *EsOutProgramAdd( es_out_t *out, es_out_ctx_t *ctx, int i_group )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div> input_thread_t *p_input = p_sys->p_input;<br></div><div>@@ -1343,6 +1365,7 @@ static es_out_pgrm_t *EsOutProgramAdd( es_out_t *out, int i_group )<br></div><div> return NULL;<br></div><div> <br></div><div> /* Init */<br></div><div>+ p_pgrm->ctx = es_out_ctx_Hold( ctx );<br></div><div> p_pgrm->i_id = i_group;<br></div><div> p_pgrm->i_es = 0;<br></div><div> p_pgrm->b_selected = false;<br></div><div>@@ -1376,7 +1399,7 @@ static es_out_pgrm_t *EsOutProgramAdd( es_out_t *out, int i_group )<br></div><div> vlc_list_append(&p_pgrm->node, &p_sys->programs);<br></div><div> <br></div><div> /* Update "program" variable */<br></div><div>- if( EsOutIsProgramVisible( out, i_group ) )<br></div><div>+ if( EsOutIsProgramVisible( out, ctx, i_group ) )<br></div><div> input_SendEventProgramAdd( p_input, i_group, NULL );<br></div><div> <br></div><div> if( i_group == p_sys->i_group_id || ( !p_sys->p_pgrm && p_sys->i_group_id == 0 ) )<br></div><div>@@ -1387,34 +1410,37 @@ static es_out_pgrm_t *EsOutProgramAdd( es_out_t *out, int i_group )<br></div><div> <br></div><div> /* EsOutProgramSearch<br></div><div> */<br></div><div>-static es_out_pgrm_t *EsOutProgramSearch( es_out_t *p_out, int i_group )<br></div><div>+static es_out_pgrm_t *EsOutProgramSearch( es_out_t *p_out, es_out_ctx_t *ctx,<br></div><div>+ int i_group )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(p_out, es_out_sys_t, out);<br></div><div> es_out_pgrm_t *pgrm;<br></div><div> <br></div><div> vlc_list_foreach(pgrm, &p_sys->programs, node)<br></div><div>- if (pgrm->i_id == i_group)<br></div><div>+ if (pgrm->i_id == i_group && (pgrm->ctx == ctx || i_group == 0))<br></div><div> return pgrm;<br></div><div>+<br></div><div> return NULL;<br></div><div> }<br></div><div> <br></div><div> /* EsOutProgramInsert<br></div><div> */<br></div><div>-static es_out_pgrm_t *EsOutProgramInsert( es_out_t *p_out, int i_group )<br></div><div>+static es_out_pgrm_t *EsOutProgramInsert( es_out_t *p_out, es_out_ctx_t *ctx,<br></div><div>+ int i_group )<br></div><div> {<br></div><div>- es_out_pgrm_t *pgrm = EsOutProgramSearch( p_out, i_group );<br></div><div>- return pgrm ? pgrm : EsOutProgramAdd( p_out, i_group );<br></div><div>+ es_out_pgrm_t *pgrm = EsOutProgramSearch( p_out, ctx, i_group );<br></div><div>+ return pgrm ? pgrm : EsOutProgramAdd( p_out, ctx, i_group );<br></div><div> }<br></div><div> <br></div><div> /* EsOutDelProgram:<br></div><div> * Delete a program<br></div><div> */<br></div><div>-static int EsOutProgramDel( es_out_t *out, int i_group )<br></div><div>+static int EsOutProgramDel( es_out_t *out, es_out_ctx_t *ctx, int i_group )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div> input_thread_t *p_input = p_sys->p_input;<br></div><div> <br></div><div>- es_out_pgrm_t *p_pgrm = EsOutProgramSearch( out, i_group );<br></div><div>+ es_out_pgrm_t *p_pgrm = EsOutProgramSearch( out, ctx, i_group );<br></div><div> if( p_pgrm == NULL )<br></div><div> return VLC_EGENERIC;<br></div><div> <br></div><div>@@ -1483,7 +1509,8 @@ static char *EsInfoCategoryName( es_out_id_t* es )<br></div><div> return psz_category;<br></div><div> }<br></div><div> <br></div><div>-static void EsOutProgramMeta( es_out_t *out, int i_group, const vlc_meta_t *p_meta )<br></div><div>+static void EsOutProgramMeta( es_out_t *out, es_out_ctx_t *ctx,<br></div><div>+ int i_group, const vlc_meta_t *p_meta )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div> es_out_pgrm_t *p_pgrm;<br></div><div>@@ -1511,9 +1538,9 @@ static void EsOutProgramMeta( es_out_t *out, int i_group, const vlc_meta_t *p_me<br></div><div> }<br></div><div> <br></div><div> /* Find program */<br></div><div>- if( !EsOutIsProgramVisible( out, i_group ) )<br></div><div>+ if( !EsOutIsProgramVisible( out, ctx, i_group ) )<br></div><div> return;<br></div><div>- p_pgrm = EsOutProgramInsert( out, i_group );<br></div><div>+ p_pgrm = EsOutProgramInsert( out, ctx, i_group );<br></div><div> if( !p_pgrm )<br></div><div> return;<br></div><div> <br></div><div>@@ -1612,7 +1639,8 @@ static void EsOutProgramMeta( es_out_t *out, int i_group, const vlc_meta_t *p_me<br></div><div> input_SendEventMetaInfo( p_input );<br></div><div> }<br></div><div> <br></div><div>-static void EsOutProgramEpgEvent( es_out_t *out, int i_group, const vlc_epg_event_t *p_event )<br></div><div>+static void EsOutProgramEpgEvent( es_out_t *out, es_out_ctx_t *ctx,<br></div><div>+ int i_group, const vlc_epg_event_t *p_event )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div> input_thread_t *p_input = p_sys->p_input;<br></div><div>@@ -1620,16 +1648,17 @@ static void EsOutProgramEpgEvent( es_out_t *out, int i_group, const vlc_epg_even<br></div><div> es_out_pgrm_t *p_pgrm;<br></div><div> <br></div><div> /* Find program */<br></div><div>- if( !EsOutIsProgramVisible( out, i_group ) )<br></div><div>+ if( !EsOutIsProgramVisible( out, ctx, i_group ) )<br></div><div> return;<br></div><div>- p_pgrm = EsOutProgramInsert( out, i_group );<br></div><div>+ p_pgrm = EsOutProgramInsert( out, ctx, i_group );<br></div><div> if( !p_pgrm )<br></div><div> return;<br></div><div> <br></div><div> input_item_SetEpgEvent( p_item, p_event );<br></div><div> }<br></div><div> <br></div><div>-static void EsOutProgramEpg( es_out_t *out, int i_group, const vlc_epg_t *p_epg )<br></div><div>+static void EsOutProgramEpg( es_out_t *out, es_out_ctx_t *ctx,<br></div><div>+ int i_group, const vlc_epg_t *p_epg )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div> input_thread_t *p_input = p_sys->p_input;<br></div><div>@@ -1638,9 +1667,9 @@ static void EsOutProgramEpg( es_out_t *out, int i_group, const vlc_epg_t *p_epg<br></div><div> char *psz_cat;<br></div><div> <br></div><div> /* Find program */<br></div><div>- if( !EsOutIsProgramVisible( out, i_group ) )<br></div><div>+ if( !EsOutIsProgramVisible( out, ctx, i_group ) )<br></div><div> return;<br></div><div>- p_pgrm = EsOutProgramInsert( out, i_group );<br></div><div>+ p_pgrm = EsOutProgramInsert( out, ctx, i_group );<br></div><div> if( !p_pgrm )<br></div><div> return;<br></div><div> <br></div><div>@@ -1874,7 +1903,8 @@ static void EsOutFillEsFmt(es_out_t *out, es_format_t *fmt)<br></div><div> }<br></div><div> }<br></div><div> <br></div><div>-static es_out_id_t *EsOutAddLocked( es_out_t *out, const es_format_t *fmt,<br></div><div>+static es_out_id_t *EsOutAddLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div>+ const es_format_t *fmt,<br></div><div> es_out_id_t *p_master )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div>@@ -1893,26 +1923,32 @@ static es_out_id_t *EsOutAddLocked( es_out_t *out, const es_format_t *fmt,<br></div><div> return NULL;<br></div><div> <br></div><div> es->out = out;<br></div><div>+ es->ctx = es_out_ctx_Hold( ctx );<br></div><div> <br></div><div> if( es_format_Copy( &es->fmt, fmt ) != VLC_SUCCESS )<br></div><div> {<br></div><div> free( es );<br></div><div> return NULL;<br></div><div> }<br></div><div>+<br></div><div> if( es->fmt.i_id < 0 )<br></div><div>- es->fmt.i_id = p_sys->i_id;<br></div><div>+ es->fmt.i_id = es_out_ctx_GetNewEsID( ctx );<br></div><div> if( !es->fmt.i_original_fourcc )<br></div><div> es->fmt.i_original_fourcc = es->fmt.i_codec;<br></div><div> <br></div><div> /* Search the program */<br></div><div>- p_pgrm = EsOutProgramInsert( out, fmt->i_group );<br></div><div>+ p_pgrm = EsOutProgramInsert( out, ctx, fmt->i_group );<br></div><div> if( !p_pgrm )<br></div><div> {<br></div><div> es_format_Clean( &es->fmt );<br></div><div>+ es_out_ctx_Release( es->ctx );<br></div><div> free( es );<br></div><div> return NULL;<br></div><div> }<br></div><div> <br></div><div>+ /* The group 0 is the default one and can be used by different contexts */<br></div><div>+ assert( fmt->i_group == 0 || p_pgrm->ctx == es->ctx );<br></div><div>+<br></div><div> /* Get the number of ES already added in order to get the position of the es */<br></div><div> es->i_pos = 0;<br></div><div> es_out_id_t *it;<br></div><div>@@ -1989,8 +2025,12 @@ static es_out_id_t *EsOutAdd( es_out_t *out, es_out_ctx_t *ctx, const es_format_<br></div><div> {<br></div><div> VLC_UNUSED(ctx);<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div>+<br></div><div>+ if( !ctx )<br></div><div>+ ctx = p_sys->main_ctx;<br></div><div>+<br></div><div> vlc_mutex_lock( &p_sys->lock );<br></div><div>- es_out_id_t *es = EsOutAddLocked( out, fmt, NULL );<br></div><div>+ es_out_id_t *es = EsOutAddLocked( out, ctx, fmt, NULL );<br></div><div> vlc_mutex_unlock( &p_sys->lock );<br></div><div> return es;<br></div><div> }<br></div><div>@@ -2481,7 +2521,7 @@ static void EsOutCreateCCChannels( es_out_t *out, vlc_fourcc_t codec, uint64_t i<br></div><div> fmt.psz_description = NULL;<br></div><div> <br></div><div> es_out_id_t **pp_es = &parent->cc.pp_es[i];<br></div><div>- *pp_es = EsOutAddLocked( out, &fmt, parent );<br></div><div>+ *pp_es = EsOutAddLocked( out, parent->p_pgrm->ctx, &fmt, parent );<br></div><div> es_format_Clean( &fmt );<br></div><div> <br></div><div> /* */<br></div><div>@@ -2750,6 +2790,7 @@ static int EsOutVaControlLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> int i_query, va_list args )<br></div><div> {<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div>+ assert( ctx ); /* == p_sys->main_ctx if the given ctx is NULL */<br></div><div> <br></div><div> switch( i_query )<br></div><div> {<br></div><div>@@ -3024,12 +3065,12 @@ static int EsOutVaControlLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> {<br></div><div> p_pgrm = p_sys->p_pgrm;<br></div><div> if( !p_pgrm )<br></div><div>- p_pgrm = EsOutProgramAdd( out, i_group ); /* Create it */<br></div><div>+ p_pgrm = EsOutProgramAdd( out, ctx, i_group ); /* Create it */<br></div><div> }<br></div><div> else<br></div><div> {<br></div><div> i_group = va_arg( args, int );<br></div><div>- p_pgrm = EsOutProgramInsert( out, i_group );<br></div><div>+ p_pgrm = EsOutProgramInsert( out, ctx, i_group );<br></div><div> }<br></div><div> if( !p_pgrm )<br></div><div> return VLC_EGENERIC;<br></div><div>@@ -3202,7 +3243,7 @@ static int EsOutVaControlLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> int i_group = va_arg( args, int );<br></div><div> const vlc_meta_t *p_meta = va_arg( args, const vlc_meta_t * );<br></div><div> <br></div><div>- EsOutProgramMeta( out, i_group, p_meta );<br></div><div>+ EsOutProgramMeta( out, ctx, i_group, p_meta );<br></div><div> return VLC_SUCCESS;<br></div><div> }<br></div><div> case ES_OUT_SET_GROUP_EPG:<br></div><div>@@ -3210,7 +3251,7 @@ static int EsOutVaControlLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> int i_group = va_arg( args, int );<br></div><div> const vlc_epg_t *p_epg = va_arg( args, const vlc_epg_t * );<br></div><div> <br></div><div>- EsOutProgramEpg( out, i_group, p_epg );<br></div><div>+ EsOutProgramEpg( out, ctx, i_group, p_epg );<br></div><div> return VLC_SUCCESS;<br></div><div> }<br></div><div> case ES_OUT_SET_GROUP_EPG_EVENT:<br></div><div>@@ -3218,7 +3259,7 @@ static int EsOutVaControlLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> int i_group = va_arg( args, int );<br></div><div> const vlc_epg_event_t *p_evt = va_arg( args, const vlc_epg_event_t * );<br></div><div> <br></div><div>- EsOutProgramEpgEvent( out, i_group, p_evt );<br></div><div>+ EsOutProgramEpgEvent( out, ctx, i_group, p_evt );<br></div><div> return VLC_SUCCESS;<br></div><div> }<br></div><div> case ES_OUT_SET_EPG_TIME:<br></div><div>@@ -3233,7 +3274,7 @@ static int EsOutVaControlLocked( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> {<br></div><div> int i_group = va_arg( args, int );<br></div><div> <br></div><div>- return EsOutProgramDel( out, i_group );<br></div><div>+ return EsOutProgramDel( out, ctx, i_group );<br></div><div> }<br></div><div> <br></div><div> case ES_OUT_SET_META:<br></div><div>@@ -3559,6 +3600,9 @@ static int EsOutControl( es_out_t *out, es_out_ctx_t *ctx,<br></div><div> es_out_sys_t *p_sys = container_of(out, es_out_sys_t, out);<br></div><div> int i_ret;<br></div><div> <br></div><div>+ if( !ctx )<br></div><div>+ ctx = p_sys->main_ctx;<br></div><div>+<br></div><div> vlc_mutex_lock( &p_sys->lock );<br></div><div> i_ret = EsOutVaControlLocked( out, ctx, i_query, args );<br></div><div> vlc_mutex_unlock( &p_sys->lock );<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>