<html><head></head><body style="zoom: 0%;"><div dir="auto">Would fixing the generic helper by replacing the uint by a uintptr be enough ? That would fix all other parts of VLC using them at the same time.</div>
<div class="gmail_quote" >On Feb 21, 2020, at 20:06, "Rémi Denis-Courmont" <<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="blue">Le perjantaina 21. helmikuuta 2020, 19.32.24 EET Quentin Chateau a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> I fail to see what you mean, can you please give me some more info so I<br> can meet your expectations:<br> <br> 1. Are you afraid of the counter overflowing the underlying unsigned int ?<br></blockquote><br>Yes.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> 2. How is it worse than before ?<br></blockquote><br>This has already been discussed before. You can overflow uint on a 64-bits <br>platform. There's already been exploits on other programs doing exactly that. <br>You can't overflow uintptr_t since you can't have that many references in a <br>single address space (and it would take forever).<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> 3. What's the point of having helper functions for reference counting<br> if we should not use them ?<br></blockquote><br>Don't ask me. They're pointless as far as I can see.<br></pre></blockquote></div></body></html>