<html><head></head><body>-1 means EAGAIN and 0 means EOF here. Fatal errors should return zero (and write to log).<br><br>Though I don't know if DSM guarantees proper errno values.<br><br><div class="gmail_quote">Le 24 février 2020 10:46:51 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br><br>On Fri, Feb 21, 2020, at 21:04, Janboe Ye wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">From 7bba85e4f3a01b5afaa624e52c7534580f840f77 Mon Sep 17 00:00:00 2001<br>From: Janboe Ye <janboe.ye@outlook.com><br>Date: Sat, 22 Feb 2020 04:00:39 +0800<br>Subject: [PATCH] dsm: add missing I/O error handling<br><br>Signed-off-by: Janboe Ye <janboe.ye@outlook.com><hr> modules/access/dsm/access.c | 2 ++<br> 1 file changed, 2 insertions(+)<br><br>diff --git a/modules/access/dsm/access.c b/modules/access/dsm/access.c<br>index 69f61b9860..795872092e 100644<br>--- a/modules/access/dsm/access.c<br>+++ b/modules/access/dsm/access.c<br>@@ -523,6 +523,8 @@ static ssize_t Read( stream_t *p_access, void <br>*p_buffer, size_t i_len )<br> if( i_read < 0 )<br> {<br> msg_Err( p_access, "read failed" );<br>+ if (errno != EINTR && errno != EAGAIN)<br></blockquote><br>It is not the contrary ?<br>EINTR or EAGAIN should not be treated as error, right ?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">+ return 0;<br> return -1;<br> }<br> <br>-- <br>2.23.0<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>