<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>You could but the common code in a common header and static inline for common<br></div><div><br></div><div>Anyway, 25% code duplication doesn't shock me.<br></div><div><br></div><div>On Sun, Feb 23, 2020, at 23:03, Kartik Ohri wrote:<br></div><blockquote type="cite" id="qt"><div dir="auto">Most of the identical code concerns reading the metadata of audio file. I think around 150 lines could be taken out common. Thats 25% of the module codebase. <br></div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On Mon, Feb 24, 2020, 3:18 AM Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org">jb@videolan.org</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><u></u><br></div><div><div>Depends, how much is in common, and how much is not?<br></div><div><br></div><div>On Sun, Feb 23, 2020, at 22:44, Kartik Ohri wrote:<br></div><blockquote id="qt-m_4736607960368471560qt" type="cite"><div dir="auto">Yes, that is correct. Should I extract the common code in a utilities file and then have the modules depend on it ?<br></div><div><br></div><div><div dir="ltr">On Mon, Feb 24, 2020, 2:56 AM Jean-Baptiste Kempf <<a rel="noreferrer" href="mailto:jb@videolan.org">jb@videolan.org</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div><br></div><div><br></div><div>On Sun, Feb 23, 2020, at 22:20, Kartik Ohri<a href="mailto:kartikohri13@gmail.com" rel="noreferrer noreferrer">kartikohri13@gmail.com</a> wrote:<br></div><div>> VLC already has the audioscrobbler module to submit scrobbles to<br></div><div>> <a href="http://last.fm" rel="noreferrer noreferrer noreferrer">last.fm</a> and other services with a similar API. This module extends<br></div><div>> that functionality to allow submission of listens to ListenBrainz.<br></div><div>> The existing audioscrobbler module is incompatible with ListenBrainz<br></div><div>> due to difference in authentication procedures and REST API for<br></div><div>> submissions.<br></div><div><br></div><div>But cannot you reuse some code of the other module?<br></div><div><br></div><div><br></div><div>-- <br></div><div>Jean-Baptiste Kempf - President<br></div><div>+33 672 704 734<br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer noreferrer">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div><div id="qt-m_4736607960368471560sig60240713"><div>--<br></div><div>Jean-Baptiste Kempf - President<br></div><div>+33 672 704 734<br></div><div> <br></div><div><br></div></div><div><br></div></div><div>_______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a rel="noreferrer noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>