<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Mon, Feb 24, 2020, at 10:03, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>-1 means EAGAIN and 0 means EOF here. Fatal errors should return zero (and write to log).<br></div></blockquote><div><br></div><div>Ah es, as explained by the stream documentation. I forgot about it.<br></div><div><br></div><div>So LGTM.<br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div>Though I don't know if DSM guarantees proper errno values.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 24 février 2020 10:46:51 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><pre class="qt-k9mail"><div><br></div><div><br></div><div>On Fri, Feb 21, 2020, at 21:04, Janboe Ye wrote:<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>From 7bba85e4f3a01b5afaa624e52c7534580f840f77 Mon Sep 17 00:00:00 2001<br></div><div>From: Janboe Ye <janboe.ye@outlook.com><br></div><div>Date: Sat, 22 Feb 2020 04:00:39 +0800<br></div><div>Subject: [PATCH] dsm: add missing I/O error handling<br></div><div><br></div><div>Signed-off-by: Janboe Ye <janboe.ye@outlook.com><hr> modules/access/dsm/access.c | 2 ++<br></div><div> 1 file changed, 2 insertions(+)<br></div><div><br></div><div>diff --git a/modules/access/dsm/access.c b/modules/access/dsm/access.c<br></div><div>index 69f61b9860..795872092e 100644<br></div><div>--- a/modules/access/dsm/access.c<br></div><div>+++ b/modules/access/dsm/access.c<br></div><div>@@ -523,6 +523,8 @@ static ssize_t Read( stream_t *p_access, void <br></div><div>*p_buffer, size_t i_len )<br></div><div> if( i_read < 0 )<br></div><div> {<br></div><div> msg_Err( p_access, "read failed" );<br></div><div>+ if (errno != EINTR && errno != EAGAIN)<br></div></blockquote><div><br></div><div>It is not the contrary ?<br></div><div>EINTR or EAGAIN should not be treated as error, right ?<br></div><div><br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>+ return 0;<br></div><div> return -1;<br></div><div> }<br></div><div> <br></div><div>-- <br></div><div>2.23.0<hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>