<html><head></head><body>Hi,<br><br>Ubuntu LTS originally uses Clang 6 as default. But it has backports of 7, 8 and 9 in the official repos.<br><br><div class="gmail_quote">Le 25 février 2020 11:51:23 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br><br>On Tue, Feb 25, 2020, at 10:33, Alexandre Janniaux wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>The main issue with requiring earlier version of Clang is<br>that it needs to be shipped in android NDK release too.<br><br>Currently it seems to be failing with android NDK 18 (which<br>is previous VLC 3 NDK version) but is ok with NDK 21 (which<br>is LTS and the current version on VLC 4 and latest VLC 3).<br><br>Is it planned to drop support of NDK 18? (or done?).<br></blockquote><br>Yes, VLC 4.0 is NDK 21 only. It is building now with NDK 18 but we shouldn't do anything to keep supporting it.<br><br>So my question: is the clang issue only happening on NDK 18 ? If so, I would tend to agree with Rémi.<br><br>What other OS/distrib are still using clang 7 ?<br><br>> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Especially not old bugs from a compiler that will be already 3 major releases behind by the time VLC 4.0 comes out, while on the other hand C++ devs are craving to use C++17 and we require bleeding edge version of some other build tools (Meson requirement is so new that you can't build contribs on current Ubuntu LTS).<br></blockquote>I don't think toolchains and buildsystems are comparable<br>with regards to version update. You can be stuck on old<br>compilers but still be able to use bleeding edge build<br>systems. The case of android is typically one of them.<br><br>Regards,<br>--<br>Alexandre Janniaux<br>Videolabs<br><br>On Tue, Feb 25, 2020 at 11:06:20AM +0200, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Hi,<br><br> I don't think it makes sense in general to try to work around compiler bugs.<br><br> Especially not old bugs from a compiler that will be already 3 major releases behind by the time VLC 4.0 comes out, while on the other hand C++ devs are craving to use C++17 and we require bleeding edge version of some other build tools (Meson requirement is so new that you can't build contribs on current Ubuntu LTS).<br><br> Le 25 février 2020 10:24:33 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><br>On Tue, Feb 25, 2020, at 08:34, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> Hi,<br><br> Clang 7 supports what you call C17. It even has a compiler flag for<br></blockquote>it explicitly. That's all in the LLVM and Clang documentation.<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">Ergo it works or your compiler is buggy.<br></blockquote>I think that is what ePirat said, clang 7 has the bug.<br><br>Could it be possible to enable this cast on a ifdef clang < 7 ?<br><br>That way, we can easily remove later when we drop clang 7 support.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">Le 25 février 2020 08:36:39 GMT+02:00, Marvin Scholz<br></blockquote><epirat07@gmail.com> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"> On 25 Feb 2020, at 6:56, Rémi Denis-Courmont wrote:<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;">Le maanantaina 24. helmikuuta 2020, 17.45.07 EET Marvin Scholz a<br>écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;">even though it never modifies it.<br>Clang versions 7 or older did implement this quite strictly and<br>therefore errors when compiling this code:<br></blockquote>That's either a bug in that compiler version or possibly a minor<br>update not<br>installed, or mistaken compiler flag (in other words, configure<br></blockquote></blockquote></blockquote>script<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;">bug).<br>Clang 7 officially supports C17/C18.<br></blockquote> I tested all major versions before 7 and all are affected.<br> I can’t easily test minor versions between 7 or 8 as they are not<br> available<br> on godbolt. Looking at the git repository though it seems the first<br> fixed<br> version was 8.0.0.<br><br> Not sure what you mean by mistaken compiler flag here?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;">And to call it C17 is a bit of a stretch. It's really just an<br>re-edition of<br>C11 with editorial corrections gathered. The atomic spelling error<br></blockquote></blockquote></blockquote>was<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;">already<br>found and corrected in 2014.<br></blockquote>It’s called C17 on open-std.org, thats why I used that here, not<br></blockquote></blockquote>sure<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"> what else to<br> call it.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;">--<br>Реми Дёни-Курмон<br><a href="http://www.remlab.net/">http://www.remlab.net/</a> vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>--<br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez<br></blockquote>excuser ma brièveté.<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote></blockquote>--<br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<br><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>