<html><head></head><body>Hi,<br><br>Looks like replacing broken code with differently broken code to me :/<br><br><div class="gmail_quote">Le 26 février 2020 16:54:20 GMT+02:00, Romain Vimont <rom1v@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">This reverts commit 77aa424b72d8b6a1e7049c430c90303b9473ed7d.<br><br>The replacement was not equivalent:<br><br> strncmp(a, b, strlen(b)) == 0 # test if a starts with b<br> strcmp(a, b) == 0 # test if a equals b<br><br>In practice, it breaks OpenGL on Android when the vout_modules contains<br>"gles2,none".<hr> modules/video_output/android/utils.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br><br>diff --git a/modules/video_output/android/utils.c b/modules/video_output/android/utils.c<br>index 25ac24676f..2010f13976 100644<br>--- a/modules/video_output/android/utils.c<br>+++ b/modules/video_output/android/utils.c<br>@@ -546,8 +546,8 @@ AWindowHandler_new(vout_window_t *wnd, awh_events_t *p_events)<br> */<br> char *vout_modules = var_InheritString(wnd, "vout");<br> if (vout_modules<br>- && (strcmp(vout_modules, "gles2") == 0<br>- || strcmp(vout_modules, "opengles2") == 0))<br>+ && (strncmp(vout_modules, "gles2", sizeof("gles2") - 1) == 0<br>+ || strncmp(vout_modules, "opengles2", sizeof("opengles2") - 1) == 0))<br> p_awh->b_has_video_layout_listener = false;<br> free(vout_modules);<br> }</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>