<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">That’s great. Thanks<div class=""><div><br class=""><blockquote type="cite" class=""><div class="">2020年2月28日 下午7:43,Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="">thomas@gllm.fr</a>> 写道:</div><br class="Apple-interchange-newline"><div class=""><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">Hello Janboe,<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">On Fri, Feb 28, 2020, at 12:23, Janboe Ye wrote:<br class=""></div><blockquote id="qt" type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="">hi, Thomas<br class=""></div><div class="qt-"><br class=""></div><div class="qt-">Is this patch ok for merge? Do I need to do anything else?<br class=""></div></blockquote><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">I merged it on Monday, I forgot to tell you.<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><blockquote id="qt" type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="qt-"><br class=""></div><div class="qt-">BTW, I created a pull request for libdsm to fix sigal issue, and there is no response for a week.<br class=""></div><div class="qt-"><a href="https://github.com/videolabs/libdsm/pull/142" class="qt-">https://github.com/videolabs/libdsm/pull/142</a><br class=""></div></blockquote><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">I just checked and merged it. Thanks for your work !<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">We'll see if we do a new libdsm release of backport your patch in contribs.<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><blockquote id="qt" type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="qt-"><br class=""></div><div class="qt-">Could you also help to check?<br class=""></div><div class="qt-"><br class=""></div><div class="qt-">Thanks a lot!<br class=""></div><div class="qt-"><br class=""></div><div class="qt-"><div class="qt-">Janboe<br class=""></div><div class="qt-"><br class=""></div><div class="qt-"><div class=""><blockquote type="cite" class="qt-"><div class="qt-">2020年2月24日 下午5:06,Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="qt-">thomas@gllm.fr</a>> 写道:<br class=""></div><div class=""><br class=""></div><div class="qt-"><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><div class=""><br class=""></div><div class="">On Mon, Feb 24, 2020, at 10:03, Rémi Denis-Courmont wrote:<br class=""></div></div><blockquote type="cite" id="qt-qt" class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><div class="qt-">-1 means EAGAIN and 0 means EOF here. Fatal errors should return zero (and write to log).<br class=""></div></blockquote><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><br class=""></div><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;">Ah es, as explained by the stream documentation. I forgot about it.<br class=""></div><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><br class=""></div><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;">So LGTM.<br class=""></div><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><br class=""></div><blockquote type="cite" id="qt-qt" class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><div class="qt-"><br class=""></div><div class="qt-">Though I don't know if DSM guarantees proper errno values.<br class=""></div><div class="qt-"><br class=""></div><div class="qt-qt-gmail_quote"><div class="qt-">Le 24 février 2020 10:46:51 GMT+02:00, Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="qt-">thomas@gllm.fr</a>> a écrit :<br class=""></div><blockquote class="qt-qt-gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left-color: rgb(204, 204, 204); border-left-style: solid; border-left-width: 1px; padding-left: 1ex;"><pre class="qt-qt-k9mail"><div class="qt-"><br class=""></div><div class="qt-"><br class=""></div><div class="qt-">On Fri, Feb 21, 2020, at 21:04, Janboe Ye wrote:<br class=""></div><blockquote class="qt-qt-gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left-color: rgb(114, 159, 207); border-left-style: solid; border-left-width: 1px; padding-left: 1ex;"><div class="qt-">From 7bba85e4f3a01b5afaa624e52c7534580f840f77 Mon Sep 17 00:00:00 2001<br class=""></div><div class="qt-">From: Janboe Ye <<a href="mailto:janboe.ye@outlook.com" class="qt-">janboe.ye@outlook.com</a>><br class=""></div><div class="qt-">Date: Sat, 22 Feb 2020 04:00:39 +0800<br class=""></div><div class="qt-">Subject: [PATCH] dsm: add missing I/O error handling<br class=""></div><div class="qt-"><br class=""></div><div class="qt-">Signed-off-by: Janboe Ye <<a href="mailto:janboe.ye@outlook.com" class="qt-">janboe.ye@outlook.com</a>><hr class="qt-"> modules/access/dsm/access.c | 2 ++<br class=""></div><div class="qt-"> 1 file changed, 2 insertions(+)<br class=""></div><div class="qt-"><br class=""></div><div class="qt-">diff --git a/modules/access/dsm/access.c b/modules/access/dsm/access.c<br class=""></div><div class="qt-">index 69f61b9860..795872092e 100644<br class=""></div><div class="qt-">--- a/modules/access/dsm/access.c<br class=""></div><div class="qt-">+++ b/modules/access/dsm/access.c<br class=""></div><div class="qt-">@@ -523,6 +523,8 @@ static ssize_t Read( stream_t *p_access, void <br class=""></div><div class="qt-">*p_buffer, size_t i_len )<br class=""></div><div class="qt-">     if( i_read < 0 )<br class=""></div><div class="qt-">     {<br class=""></div><div class="qt-">         msg_Err( p_access, "read failed" );<br class=""></div><div class="qt-">+        if (errno != EINTR && errno != EAGAIN)<br class=""></div></blockquote><div class="qt-"><br class=""></div><div class="qt-">It is not the contrary ?<br class=""></div><div class="qt-">EINTR or EAGAIN should not be treated as error, right ?<br class=""></div><div class="qt-"><br class=""></div><blockquote class="qt-qt-gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left-color: rgb(114, 159, 207); border-left-style: solid; border-left-width: 1px; padding-left: 1ex;"><div class="qt-">+            return 0;<br class=""></div><div class="qt-">         return -1;<br class=""></div><div class="qt-">     }<br class=""></div><div class="qt-"> <br class=""></div><div class="qt-">-- <br class=""></div><div class="qt-">2.23.0<hr class="qt-">vlc-devel mailing list<br class=""></div><div class="qt-">To unsubscribe or modify your subscription options:<br class=""></div><div class="qt-"><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></blockquote><div class="qt-"><hr class="qt-">vlc-devel mailing list<br class=""></div><div class="qt-">To unsubscribe or modify your subscription options:<br class=""></div><div class="qt-"><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></pre></blockquote></div><div class="qt-"><br class=""></div><div class="qt-">--<span class="qt-Apple-converted-space"> </span><br class=""></div><div class="qt-">Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<span class="qt-Apple-converted-space"> </span><br class=""></div><div class="qt-">_______________________________________________<br class=""></div><div class="qt-">vlc-devel mailing list<br class=""></div><div class="qt-">To unsubscribe or modify your subscription options:<br class=""></div><div class="qt-"><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></blockquote><div class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto;"><br class=""></div><div class=""><span class="qt-" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto; float: none; display: inline !important;"><span class="font" style="font-family: Helvetica;"><span class="size" style="font-size: 12px;">_______________________________________________</span></span></span><br class=""></div><div class=""><span class="qt-" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto; float: none; display: inline !important;"><span class="font" style="font-family: Helvetica;"><span class="size" style="font-size: 12px;">vlc-devel mailing list</span></span></span><br class=""></div><div class=""><span class="qt-" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-line: none; text-decoration-style: solid; text-decoration-color: currentcolor; text-decoration-thickness: auto; float: none; display: inline !important;"><span class="font" style="font-family: Helvetica;"><span class="size" style="font-size: 12px;">To unsubscribe or modify your subscription options:</span></span></span><br class=""></div><div class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></div></blockquote></div></div></div><div class="">_______________________________________________<br class=""></div><div class="">vlc-devel mailing list<br class=""></div><div class="">To unsubscribe or modify your subscription options:<br class=""></div><div class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></blockquote><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">_______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">vlc-devel mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">To unsubscribe or modify your subscription options:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://mailman.videolan.org/listinfo/vlc-devel</a></div></blockquote></div><br class=""></div></body></html>