<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hello Janboe,<br></div><div><br></div><div>On Fri, Feb 28, 2020, at 12:23, Janboe Ye wrote:<br></div><blockquote id="qt" type="cite"><div>hi, Thomas<br></div><div class="qt-"><br></div><div class="qt-">Is this patch ok for merge? Do I need to do anything else?<br></div></blockquote><div><br></div><div>I merged it on Monday, I forgot to tell you.<br></div><div><br></div><blockquote id="qt" type="cite"><div class="qt-"><br></div><div class="qt-">BTW, I created a pull request for libdsm to fix sigal issue, and there is no response for a week.<br></div><div class="qt-"><a href="https://github.com/videolabs/libdsm/pull/142" class="qt-">https://github.com/videolabs/libdsm/pull/142</a><br></div></blockquote><div><br></div><div>I just checked and merged it. Thanks for your work !<br></div><div><br></div><div>We'll see if we do a new libdsm release of backport your patch in contribs.<br></div><div><br></div><blockquote id="qt" type="cite"><div class="qt-"><br></div><div class="qt-">Could you also help to check?<br></div><div class="qt-"><br></div><div class="qt-">Thanks a lot!<br></div><div class="qt-"><br></div><div class="qt-"><div class="qt-">Janboe<br></div><div class="qt-"><br></div><div class="qt-"><div><blockquote type="cite" class="qt-"><div class="qt-">2020年2月24日 下午5:06，Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="qt-">thomas@gllm.fr</a>> 写道：<br></div><div><br></div><div class="qt-"><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><div><br></div><div>On Mon, Feb 24, 2020, at 10:03, Rémi Denis-Courmont wrote:<br></div></div><blockquote type="cite" id="qt-qt" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-moz-text-size-adjust:auto;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><div class="qt-">-1 means EAGAIN and 0 means EOF here. Fatal errors should return zero (and write to log).<br></div></blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-">Ah es, as explained by the stream documentation. I forgot about it.<br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-">So LGTM.<br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><br></div><blockquote type="cite" id="qt-qt" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-moz-text-size-adjust:auto;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><div class="qt-"><br></div><div class="qt-">Though I don't know if DSM guarantees proper errno values.<br></div><div class="qt-"><br></div><div class="qt-qt-gmail_quote"><div class="qt-">Le 24 février 2020 10:46:51 GMT+02:00, Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="qt-">thomas@gllm.fr</a>> a écrit :<br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-qt-k9mail"><div class="qt-"><br></div><div class="qt-"><br></div><div class="qt-">On Fri, Feb 21, 2020, at 21:04, Janboe Ye wrote:<br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div class="qt-">From 7bba85e4f3a01b5afaa624e52c7534580f840f77 Mon Sep 17 00:00:00 2001<br></div><div class="qt-">From: Janboe Ye <<a href="mailto:janboe.ye@outlook.com" class="qt-">janboe.ye@outlook.com</a>><br></div><div class="qt-">Date: Sat, 22 Feb 2020 04:00:39 +0800<br></div><div class="qt-">Subject: [PATCH] dsm: add missing I/O error handling<br></div><div class="qt-"><br></div><div class="qt-">Signed-off-by: Janboe Ye <<a href="mailto:janboe.ye@outlook.com" class="qt-">janboe.ye@outlook.com</a>><hr class="qt-"> modules/access/dsm/access.c | 2 ++<br></div><div class="qt-"> 1 file changed, 2 insertions(+)<br></div><div class="qt-"><br></div><div class="qt-">diff --git a/modules/access/dsm/access.c b/modules/access/dsm/access.c<br></div><div class="qt-">index 69f61b9860..795872092e 100644<br></div><div class="qt-">--- a/modules/access/dsm/access.c<br></div><div class="qt-">+++ b/modules/access/dsm/access.c<br></div><div class="qt-">@@ -523,6 +523,8 @@ static ssize_t Read( stream_t *p_access, void <br></div><div class="qt-">*p_buffer, size_t i_len )<br></div><div class="qt-"> if( i_read < 0 )<br></div><div class="qt-"> {<br></div><div class="qt-"> msg_Err( p_access, "read failed" );<br></div><div class="qt-">+ if (errno != EINTR && errno != EAGAIN)<br></div></blockquote><div class="qt-"><br></div><div class="qt-">It is not the contrary ?<br></div><div class="qt-">EINTR or EAGAIN should not be treated as error, right ?<br></div><div class="qt-"><br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div class="qt-">+ return 0;<br></div><div class="qt-"> return -1;<br></div><div class="qt-"> }<br></div><div class="qt-"> <br></div><div class="qt-">-- <br></div><div class="qt-">2.23.0<hr class="qt-">vlc-devel mailing list<br></div><div class="qt-">To unsubscribe or modify your subscription options:<br></div><div class="qt-"><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div class="qt-"><hr class="qt-">vlc-devel mailing list<br></div><div class="qt-">To unsubscribe or modify your subscription options:<br></div><div class="qt-"><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div class="qt-"><br></div><div class="qt-">--<span class="qt-Apple-converted-space"> </span><br></div><div class="qt-">Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<span class="qt-Apple-converted-space"> </span><br></div><div class="qt-">_______________________________________________<br></div><div class="qt-">vlc-devel mailing list<br></div><div class="qt-">To unsubscribe or modify your subscription options:<br></div><div class="qt-"><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;" class="qt-"><br></div><div><span style="font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;float:none;display:inline !important;" class="qt-"><span class="font" style="font-family:Helvetica;"><span class="size" style="font-size:12px;">_______________________________________________</span></span></span><br></div><div><span style="font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;float:none;display:inline !important;" class="qt-"><span class="font" style="font-family:Helvetica;"><span class="size" style="font-size:12px;">vlc-devel mailing list</span></span></span><br></div><div><span style="font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;float:none;display:inline !important;" class="qt-"><span class="font" style="font-family:Helvetica;"><span class="size" style="font-size:12px;">To unsubscribe or modify your subscription options:</span></span></span><br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;-moz-text-size-adjust:auto;-webkit-text-stroke-width:0px;" class="qt-">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></div></blockquote></div></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>