<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">hi, Thomas<div class=""><br class=""></div><div class="">Is this patch ok for merge? Do I need to do anything else?</div><div class=""><br class=""></div><div class="">BTW, I created a pull request for libdsm to fix sigal issue, and there is no response for a week.</div><div class=""><a href="https://github.com/videolabs/libdsm/pull/142" class="">https://github.com/videolabs/libdsm/pull/142</a></div><div class=""><br class=""></div><div class="">Could you also help to check?</div><div class=""><br class=""></div><div class="">Thanks a lot!</div><div class=""><br class=""></div><div class=""><div class="">Janboe</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">2020年2月24日 下午5:06，Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="">thomas@gllm.fr</a>> 写道：</div><br class="Apple-interchange-newline"><div class=""><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="Apple-interchange-newline">On Mon, Feb 24, 2020, at 10:03, Rémi Denis-Courmont wrote:<br class=""></div><blockquote type="cite" id="qt" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="">-1 means EAGAIN and 0 means EOF here. Fatal errors should return zero (and write to log).<br class=""></div></blockquote><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">Ah es, as explained by the stream documentation. I forgot about it.<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">So LGTM.<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><blockquote type="cite" id="qt" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class=""><br class=""></div><div class="">Though I don't know if DSM guarantees proper errno values.<br class=""></div><div class=""><br class=""></div><div class="qt-gmail_quote"><div class="">Le 24 février 2020 10:46:51 GMT+02:00, Thomas Guillem <<a href="mailto:thomas@gllm.fr" class="">thomas@gllm.fr</a>> a écrit :<br class=""></div><blockquote class="qt-gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left-color: rgb(204, 204, 204); border-left-style: solid; border-left-width: 1px; padding-left: 1ex;"><pre class="qt-k9mail"><div class=""><br class=""></div><div class=""><br class=""></div><div class="">On Fri, Feb 21, 2020, at 21:04, Janboe Ye wrote:<br class=""></div><blockquote class="qt-gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left-color: rgb(114, 159, 207); border-left-style: solid; border-left-width: 1px; padding-left: 1ex;"><div class="">From 7bba85e4f3a01b5afaa624e52c7534580f840f77 Mon Sep 17 00:00:00 2001<br class=""></div><div class="">From: Janboe Ye <<a href="mailto:janboe.ye@outlook.com" class="">janboe.ye@outlook.com</a>><br class=""></div><div class="">Date: Sat, 22 Feb 2020 04:00:39 +0800<br class=""></div><div class="">Subject: [PATCH] dsm: add missing I/O error handling<br class=""></div><div class=""><br class=""></div><div class="">Signed-off-by: Janboe Ye <<a href="mailto:janboe.ye@outlook.com" class="">janboe.ye@outlook.com</a>><hr class=""> modules/access/dsm/access.c | 2 ++<br class=""></div><div class=""> 1 file changed, 2 insertions(+)<br class=""></div><div class=""><br class=""></div><div class="">diff --git a/modules/access/dsm/access.c b/modules/access/dsm/access.c<br class=""></div><div class="">index 69f61b9860..795872092e 100644<br class=""></div><div class="">--- a/modules/access/dsm/access.c<br class=""></div><div class="">+++ b/modules/access/dsm/access.c<br class=""></div><div class="">@@ -523,6 +523,8 @@ static ssize_t Read( stream_t *p_access, void <br class=""></div><div class="">*p_buffer, size_t i_len )<br class=""></div><div class=""> if( i_read < 0 )<br class=""></div><div class=""> {<br class=""></div><div class=""> msg_Err( p_access, "read failed" );<br class=""></div><div class="">+ if (errno != EINTR && errno != EAGAIN)<br class=""></div></blockquote><div class=""><br class=""></div><div class="">It is not the contrary ?<br class=""></div><div class="">EINTR or EAGAIN should not be treated as error, right ?<br class=""></div><div class=""><br class=""></div><blockquote class="qt-gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left-color: rgb(114, 159, 207); border-left-style: solid; border-left-width: 1px; padding-left: 1ex;"><div class="">+ return 0;<br class=""></div><div class=""> return -1;<br class=""></div><div class=""> }<br class=""></div><div class=""> <br class=""></div><div class="">-- <br class=""></div><div class="">2.23.0<hr class="">vlc-devel mailing list<br class=""></div><div class="">To unsubscribe or modify your subscription options:<br class=""></div><div class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></blockquote><div class=""><hr class="">vlc-devel mailing list<br class=""></div><div class="">To unsubscribe or modify your subscription options:<br class=""></div><div class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></pre></blockquote></div><div class=""><br class=""></div><div class="">--<span class="Apple-converted-space"> </span><br class=""></div><div class="">Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<span class="Apple-converted-space"> </span><br class=""></div><div class="">_______________________________________________<br class=""></div><div class="">vlc-devel mailing list<br class=""></div><div class="">To unsubscribe or modify your subscription options:<br class=""></div><div class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="">https://mailman.videolan.org/listinfo/vlc-devel</a><br class=""></div></blockquote><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">_______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">vlc-devel mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">To unsubscribe or modify your subscription options:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://mailman.videolan.org/listinfo/vlc-devel</a></div></blockquote></div><br class=""></div></div></body></html>