<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Now that the helpers have been fixed, does this patchset look
good to you ?<br>
</p>
<div class="moz-cite-prefix">On 21/02/2020 21:13, Quentin Chateau
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:b362f208-c773-4e62-87b6-0e43a5bb2222@deepskycorp.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">Would fixing the generic helper by replacing the
uint by a uintptr be enough ? That would fix all other parts of
VLC using them at the same time.</div>
<div class="gmail_quote">On Feb 21, 2020, at 20:06, "Rémi
Denis-Courmont" <<a href="mailto:remi@remlab.net"
target="_blank" moz-do-not-send="true">remi@remlab.net</a>>
wrote:
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<pre class="blue">Le perjantaina 21. helmikuuta 2020, 19.32.24 EET Quentin Chateau a écrit :
<blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> I fail to see what you mean, can you please give me some more info so I
can meet your expectations:
1. Are you afraid of the counter overflowing the underlying unsigned int ?
</blockquote>
Yes.
<blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> 2. How is it worse than before ?
</blockquote>
This has already been discussed before. You can overflow uint on a 64-bits
platform. There's already been exploits on other programs doing exactly that.
You can't overflow uintptr_t since you can't have that many references in a
single address space (and it would take forever).
<blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> 3. What's the point of having helper functions for reference counting
if we should not use them ?
</blockquote>
Don't ask me. They're pointless as far as I can see.
</pre>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
</body>
</html>