<!DOCTYPE html><html><head><title></title><style type="text/css">
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Set merged, thanks!<br></div><div><br></div><div>On Wed, Mar 11, 2020, at 12:54, Quentin Chateau wrote:<br></div><blockquote type="cite" id="qt"><p>Hi,<br></p><p>ping on this patchset<br></p><p>Have a nice day<br></p><div class="qt-moz-cite-prefix">On 03/03/2020 11:30, Thomas Guillem
wrote:<br></div><blockquote type="cite" cite="mid:4068e6f2-d7c1-429c-89c2-6dca80786d03@www.fastmail.com"><div>Yes for me.<br></div><div><br></div><div>On Tue, Mar 3, 2020, at 11:23, Quentin Chateau wrote:<br></div><blockquote type="cite" id="qt-qt"><p>Now that the helpers have been fixed, does this patchset look
good to you ?<br></p><div class="qt-qt-moz-cite-prefix">On 21/02/2020 21:13, Quentin
Chateau wrote:<br></div><blockquote type="cite" cite="mid:b362f208-c773-4e62-87b6-0e43a5bb2222@deepskycorp.com"><div dir="auto">Would fixing the generic helper by replacing
the uint by a uintptr be enough ? That would fix all other
parts of VLC using them at the same time.<br></div><div class="qt-qt-gmail_quote"><div>On Feb 21, 2020, at 20:06, "Rémi Denis-Courmont" <<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>> wrote: <br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-qt-blue"><div>Le perjantaina 21. helmikuuta 2020, 19.32.24 EET Quentin Chateau a écrit :
<br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"> I fail to see what you mean, can you please give me some more info so I
can meet your expectations:
1. Are you afraid of the counter overflowing the underlying unsigned int ?
<br></blockquote><div>
Yes.
<br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"> 2. How is it worse than before ?
<br></blockquote><div>
This has already been discussed before. You can overflow uint on a 64-bits
platform. There's already been exploits on other programs doing exactly that.
You can't overflow uintptr_t since you can't have that many references in a
single address space (and it would take forever).
<br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"> 3. What's the point of having helper functions for reference counting
if we should not use them ?
<br></blockquote><div>
Don't ask me. They're pointless as far as I can see.
<br></div></pre></blockquote></div><div><br></div><pre class="qt-qt-moz-quote-pre">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="qt-qt-moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>
<br></pre></blockquote><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a class="qt-moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div><pre class="qt-moz-quote-pre">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="qt-moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>