<div dir="ltr"><div dir="ltr">On Tue, Mar 17, 2020 at 12:22 AM Frederik “Freso” S. Olesen <<a href="mailto:freso.dk@gmail.com">freso.dk@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Den 08.03.2020 kl. 18.14 skrev Kartik Ohri:<br>
> +typedef struct listen_t<br>
> +{<br>
> +    char *psz_artist;<br>
> +    char *psz_title;<br>
> +    char *psz_album;<br>
> +    char *psz_track_number;<br>
> +    int i_length;<br>
> +    char *psz_musicbrainz_id;<br>
<br>
I would maybe call this `musicbrainz_recording_id` or something to this<br>
effect, to keep the option open for including and submitting more MBIDs<br>
in the future.<br>
<br></blockquote><div>I'll do that. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +    time_t date;<br>
> +} listen_t;<br>
[…]<br>
> +    if ( !b_skip )<br>
> +    {<br>
> +        RETRIEVE_METADATA(p_sys->p_current_song.psz_album, Album);<br>
> +        RETRIEVE_METADATA(p_sys->p_current_song.psz_musicbrainz_id, TrackID);<br>
<br>
Is TrackID the VLC internal name for MB Recording IDs? So you can’t (or<br>
shouldn’t) change it here?<br>
<br></blockquote><div>Yes, it is. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +        RETRIEVE_METADATA(p_sys->p_current_song.psz_track_number, TrackNum);<br>
> +        p_sys->p_current_song.i_length = SEC_FROM_VLC_TICK (input_item_GetDuration (item));<br>
> +        msg_Dbg (p_this, "Meta data registered");<br>
> +        vlc_cond_signal (&p_sys->wait);<br>
> +    }<br>
<br>
-- <br>
Solidarity,<br>
Frederik “Freso” S. Olesen <<a href="https://freso.dk/" rel="noreferrer" target="_blank">https://freso.dk/</a>><br>
<br>
Like what I do? Check out <<a href="https://www.patreon.com/Freso" rel="noreferrer" target="_blank">https://www.patreon.com/Freso</a>>!<br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div>