<html><head></head><body style="zoom: 0%;"><div dir="auto">Hi,<br><br></div>
<div dir="auto">interop->priv is set only at the end of the Open function. Which means <br></div>
<div dir="auto">it will be NULL in an earlier call to Close.</div>
<div class="gmail_quote" >On Apr 7, 2020, at 07:48, Steve Lhomme <<a href="mailto:robux4@ycbcr.xyz" target="_blank">robux4@ycbcr.xyz</a>> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="blue">Hi,<br><br>I still think the commit is wrong, unless you explain how you get the <br>segfault.<br>The code is OK.<br><br>On 2020-04-06 17:43, quentin.chateau@deepskycorp.com wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> From: Quentin Chateau <quentin.chateau@deepskycorp.com><br> <br> ---<br> modules/hw/nvdec/nvdec_gl.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/modules/hw/nvdec/nvdec_gl.c b/modules/hw/nvdec/nvdec_gl.c<br> index 137e730028..9d994b40cd 100644<br> --- a/modules/hw/nvdec/nvdec_gl.c<br> +++ b/modules/hw/nvdec/nvdec_gl.c<br> @@ -212,7 +212,7 @@ static int Open(vlc_object_t *obj)<br> int ret = opengl_interop_init(interop, GL_TEXTURE_2D, render_chroma, interop-><a href="http://fmt.space">fmt.space</a>);<br> if (ret != VLC_SUCCESS)<br> {<br> - Close(obj);<br> + vlc_decoder_device_Release(device);<br> return ret;<br> }<br> <br> -- <br> 2.17.1<br> <br><hr><br> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br> <br></blockquote><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div></body></html>