<html><head></head><body>I mean that overriding parts, but not all, of the toolchain should not be done by default. It's just calling for problems when somebody uses a toolchain that's not exactly like yours.<br><br><div class="gmail_quote">Le 8 avril 2020 09:52:34 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-04-07 16:06, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le tiistaina 7. huhtikuuta 2020, 16.11.37 EEST Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">diff --git a/contrib/src/libssp/rules.mak b/contrib/src/libssp/rules.mak<br>new file mode 100644<br>index 00000000000..42fed0c714b<br>--- /dev/null<br>+++ b/contrib/src/libssp/rules.mak<br>@@ -0,0 +1,28 @@<br>+# libssp<br>+LIBSSP_VERSION := 9_2_0<br>+LIBSSP_SVNURL :=<br>svn://gcc.gnu.org/svn/gcc/tags/gcc_$(LIBSSP_VERSION)_release/libssp +<br>+ifdef HAVE_WIN32<br>+PKGS += libssp<br>+endif<br></blockquote>This really just a more general and abstract respin of Martin's question, but<br>I think overriding a toolchain library is a very bad idea.<br><br>Conversely, *if* it's really necessary, then it should be disabled by default.<br></blockquote><br>The move to bcrypt is needed for winstore/uwp/uap builds. For win32 it <br>really depends if we want to keep a chance to support XP or not (I vote <br>no). We may also decide that the one from the toolchain (which is not <br>officially part of LLVM ? A package detection would be nice) is good enough.<br><br>I'll submit the patch to move away from wincrypt, so hopefully we won't <br>even need to patch in the future.<br><br>As for "it should be disabled by default" do you mean bcrypt in libssp <br>or libssp in VLC ?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">+<br>+$(TARBALLS)/libssp-$(LIBSSP_VERSION).tar.gz:<br>+ rm -rf libssp-$(LIBSSP_VERSION) libssp<br>+ $(SVN) checkout -q $(LIBSSP_SVNURL)<br>+ rm -rf libssp/.svn<br>+ mv libssp libssp-$(LIBSSP_VERSION)<br>+ tar czf $@ libssp-$(LIBSSP_VERSION)<br>+<br>+.sum-libssp: libssp-$(LIBSSP_VERSION).tar.gz<br>+<br>+libssp: libssp-$(LIBSSP_VERSION).tar.gz .sum-libssp<br>+ $(UNPACK)<br>+ $(APPLY)<br>$(SRC)/libssp/0001-favor-bcrypt-over-wincrypt-for-the-random-generator-.pat<br>ch + $(APPLY)<br>$(SRC)/libssp/0002-allow-building-outside-of-the-gcc-tree.patch + $(MOVE)<br>+<br>+.libssp: libssp<br>+ $(RECONF)<br>+ cd $< && $(HOSTVARS) ./configure $(HOSTCONF)<br>+ cd $< && $(MAKE) install<br>+ touch $@<br></blockquote><br>-- <br>Rémi Denis-Courmont<br>Hagalund ny stad, Nylands republik<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>