<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Mon, Apr 20, 2020, at 19:27, Mark Lee wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr"><div dir="ltr"><div>Hi,<br></div><div><br></div><div>The --sub-text-scale command-line switch was already an integer in VLC 3.x, and internally uses var_CreateInteger, var_GetInteger and so on.<br></div><div><br></div><div>From the review comments so far:<br></div><div>- you would prefer float rather than int for the proposed new LibVLC API method<br></div><div>- you do not want to have mismatched float for the LibVLC API and int for the corresponding VLC command line option<br></div><div><br></div><div>So does that mean for this patch to be acceptable you would want it to include a change to the preexisting --sub-text-scale switch to make that switch a float instead of an int?<br></div></div></div></blockquote><div><br></div><div>Hello, your last patch is OK for me. I will merge it tomorrow if there is no other comments from VLC developers.<br></div><div><br></div><div>Bonus: should we change the --sub-text-scale type ? But this doesn't prevent your patch to be merged.<br></div><div><br></div><blockquote type="cite" id="qt"><div dir="ltr"><div dir="ltr"><div><br></div><div>Regards,<br></div><div><br></div></div><div class="qt-gmail_quote"><div dir="ltr" class="qt-gmail_attr">On Mon, 20 Apr 2020 at 14:56, Rémi Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>> wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>Le maanantaina 20. huhtikuuta 2020, 15.34.44 EEST Thomas Guillem a écrit :<br></div><div> > Hello, thanks for this patch and for responding to our review very quickly.<br></div><div> > <br></div><div> > I don't have any preferences regarding Integer of float for scale. But do we<br></div><div> > really want to have float for libvlc and int for vlc command line options ?<br></div><div> <br></div><div> Of course not. We use float everywhere except UI, e.g. --rate or --zoom.<br></div><div> <br></div><div> <br></div><div> -- <br></div><div> 雷米‧德尼-库尔蒙<br></div><div> <a href="http://www.remlab.net/" rel="noreferrer" target="_blank">http://www.remlab.net/</a><br></div><div> Rémi Denis-Courmont<br></div><div> <br></div><div> <br></div><div> <br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div><div><br></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>