<html><head></head><body>Hi,<br><br>Fractions are better where fractions are routinely expected, notably aspect and crop ratii. For zoom, I'm not sure anybody uses fractions, but I can live with it.<br><br>The single precision is enough for a pixel accurate ratio though. It's not like we have video formats with more than 16 millions rows or columns.<br><br><div class="gmail_quote">Le 21 avril 2020 10:27:49 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-04-20 20:33, Thomas Guillem wrote:<br>> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>On Mon, Apr 20, 2020, at 19:27, Mark Lee wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Hi,<br><br> The --sub-text-scale command-line switch was already an integer in VLC <br> 3.x, and internally uses var_CreateInteger, var_GetInteger and so on.<br><br> From the review comments so far:<br> - you would prefer float rather than int for the proposed new LibVLC <br> API method<br> - you do not want to have mismatched float for the LibVLC API and int <br> for the corresponding VLC command line option<br><br> So does that mean for this patch to be acceptable you would want it to <br> include a change to the preexisting --sub-text-scale switch to make <br> that switch a float instead of an int?<br></blockquote>Hello, your last patch is OK for me. I will merge it tomorrow if there <br>is no other comments from VLC developers.<br><br>Bonus: should we change the --sub-text-scale type ? But this doesn't <br>prevent your patch to be merged.<br></blockquote><br>A fraction would be better than an integer or float IMO. This way you <br>can express precisely in pixels relative to the full video size. I'm not <br>sure "real" numbers make sense here.<br><br>>><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Regards,<br><br> On Mon, 20 Apr 2020 at 14:56, Rémi Denis-Courmont <remi@remlab.net <br> <mailto:remi@remlab.net>> wrote:<br><br> Le maanantaina 20. huhtikuuta 2020, 15.34.44 EEST Thomas Guillem a<br> écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Hello, thanks for this patch and for responding to our review<br></blockquote>very quickly.<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">I don't have any preferences regarding Integer of float for<br></blockquote>scale. But do we<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">really want to have float for libvlc and int for vlc command<br></blockquote> line options ?<br><br> Of course not. We use float everywhere except UI, e.g. --rate or<br> --zoom.<br><br><br> -- <br> 雷米‧德尼-库尔蒙<br> <a href="http://www.remlab.net/">http://www.remlab.net/</a><br> Rémi Denis-Courmont<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>