<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Merged, thanks !<br></div><div><br></div><div>On Wed, Apr 22, 2020, at 06:13, Steve Lhomme wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr">Ok with float then <br></div><div dir="ltr"><div><br></div><blockquote type="cite"><div>On 21 Apr 2020, at 14:24, Rémi Denis-Courmont <remi@remlab.net> wrote:<br></div></blockquote></div><blockquote type="cite"><div dir="ltr"><div>Hi,<br></div><div><br></div><div>Fractions are better where fractions are routinely expected, notably aspect and crop ratii. For zoom, I'm not sure anybody uses fractions, but I can live with it.<br></div><div><br></div><div>The single precision is enough for a pixel accurate ratio though. It's not like we have video formats with more than 16 millions rows or columns.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 21 avril 2020 10:27:49 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-k9mail"><div>On 2020-04-20 20:33, Thomas Guillem wrote:<br></div><div>> <br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div><br></div><div>On Mon, Apr 20, 2020, at 19:27, Mark Lee wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(173, 127, 168);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> Hi,<br></div><div><br></div><div> The --sub-text-scale command-line switch was already an integer in VLC <br></div><div> 3.x, and internally uses var_CreateInteger, var_GetInteger and so on.<br></div><div><br></div><div> From the review comments so far:<br></div><div> - you would prefer float rather than int for the proposed new LibVLC <br></div><div> API method<br></div><div> - you do not want to have mismatched float for the LibVLC API and int <br></div><div> for the corresponding VLC command line option<br></div><div><br></div><div> So does that mean for this patch to be acceptable you would want it to <br></div><div> include a change to the preexisting --sub-text-scale switch to make <br></div><div> that switch a float instead of an int?<br></div></blockquote><div>Hello, your last patch is OK for me. I will merge it tomorrow if there <br></div><div>is no other comments from VLC developers.<br></div><div><br></div><div>Bonus: should we change the --sub-text-scale type ? But this doesn't <br></div><div>prevent your patch to be merged.<br></div></blockquote><div><br></div><div>A fraction would be better than an integer or float IMO. This way you <br></div><div>can express precisely in pixels relative to the full video size. I'm not <br></div><div>sure "real" numbers make sense here.<br></div><div><br></div><div>>><br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(173, 127, 168);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> Regards,<br></div><div><br></div><div> On Mon, 20 Apr 2020 at 14:56, Rémi Denis-Courmont <remi@remlab.net <br></div><div> <mailto:remi@remlab.net>> wrote:<br></div><div><br></div><div> Le maanantaina 20. huhtikuuta 2020, 15.34.44 EEST Thomas Guillem a<br></div><div> écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;">Hello, thanks for this patch and for responding to our review<br></blockquote><div>very quickly.<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;">I don't have any preferences regarding Integer of float for<br></blockquote><div>scale. But do we<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;">really want to have float for libvlc and int for vlc command<br></blockquote><div> line options ?<br></div><div><br></div><div> Of course not. We use float everywhere except UI, e.g. --rate or<br></div><div> --zoom.<br></div><div><br></div><div><br></div><div> -- <br></div><div> 雷米‧德尼-库尔蒙<br></div><div> <a href="http://www.remlab.net/">http://www.remlab.net/</a><br></div><div> Rémi Denis-Courmont<hr> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><hr> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<span>_______________________________________________</span><br></div><div><span>vlc-devel mailing list</span><br></div><div><span>To unsubscribe or modify your subscription options:</span><br></div><div><span>https://mailman.videolan.org/listinfo/vlc-devel</span><br></div></div></blockquote><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote></body></html>