<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Fri, Apr 24, 2020, at 09:14, Mark Lee wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr"><div>Hi,<br></div><div><br></div><div><div>With latest master, when trying to play RTSP I see assertion failures in config/core.c where it asserts that a configuration value is not null.<br></div><div><br></div><div>These assertions are triggered by calls in modules/stream_out/rtsp.c:<br></div></div></div></blockquote><div><br></div><div>Hello, thanks for the report !<br></div><div><br></div><blockquote type="cite" id="qt"><div dir="ltr"><div><div><br></div><div>RtspSetup() has this:<br></div><div><br></div><div> rtsp->timeout = vlc_tick_from_sec(__MAX(0,var_InheritInteger(owner, "rtsp-timeout")));<br></div><div> char *user = var_InheritString(owner, "sout-rtsp-user");<br></div><div> char *pwd = var_InheritString(owner, "sout-rtsp-pwd");<br></div><div><br></div><div>RtspAddId() has this:<br></div><div><br></div><div> char *user = var_InheritString(rtsp->owner, "sout-rtsp-user");<br></div><div> char *pwd = var_InheritString(rtsp->owner, "sout-rtsp-pwd");<br></div><div><br></div><div>It looks like these variables were removed from modules/stream_out/rtp.c as part of 3b684b:<br></div><div><br></div><div>- add_integer( "rtsp-timeout", 60, RTSP_TIMEOUT_TEXT,<br></div><div>- RTSP_TIMEOUT_LONGTEXT, true )<br></div><div>- add_string( "sout-rtsp-user", "",<br></div><div>- RTSP_USER_TEXT, RTSP_USER_LONGTEXT, true )<br></div><div>- add_password("sout-rtsp-pwd", "", RTSP_PASS_TEXT, RTSP_PASS_LONGTEXT)<br></div></div></div></blockquote><div><br></div><div>I think the correct fix is to add back these 3 variables ^^<br></div><div><br></div><div>Rémi, what do you think ?<br></div><div><br></div><blockquote type="cite" id="qt"><div dir="ltr"><div><div><br></div><div>Consequently there's the assertion failures, and it's no longer possible to use VLC to setup a password protected RTSP stream is it?<br></div><div dir="ltr" class="qt-gmail_signature"><br></div></div><div><br></div><div>Regards,<br></div><div><br></div><div>-M.<br></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>