<html><head></head><body>I have no idea what you are on about, sorry.<br><br><div class="gmail_quote">Le 30 avril 2020 12:07:38 GMT+03:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi,<br><br>This is right indeed for binutils, but I also have<br><br>x86_64-apple-darwin-ar / nm / ranlib... without the -gcc<br>suffix (since, maybe, it is coming with clang and not gcc).<br><br>Likewise, another flaw of this patch is that macosx doesn't<br>have prefixed tools so you should actually use ar/nm directly<br>when cross compiling to apple devices.<br><br>I was wondering if we should add the `xcrun --find` here as<br>it is still needed in the buildscript to run the configure<br>step, and we would probably want to use =? syntax which<br>disallow the same hack as I wrote for symbols.mk.<br><br>In the mean time, passing --nm=$(NM) for ffmpeg is needed but<br>currently not really correct since NM is not even defined by<br>the default makefile rules (make -p), even if it doesn't<br>really have any consequences for our builds.<br><br>I wanted to have fallback first, but I didn't know how to<br>write the detection in a valid way for all platforms,<br>especially Windows ones. This would probably allow fixing<br>those issues in a smarter way.<br><br>Regards,<br>--<br>Alexandre Janniaux<br>Videolabs<br><br>On Thu, Apr 30, 2020 at 11:44:26AM +0300, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Ok but correct value for GCC is gcc-nm (also gcc-ranlib and gcc-ar so you could argue that it's a preexisting condition).<br><br> Le 29 avril 2020 23:40:49 GMT+03:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">ffmpeg rules.make is passing the variable to configure, and nm can be<br>present in different flavour, for example in linux/macosx<br>cross-compilation environments.<hr> contrib/src/main.mak | 2 ++<br> 1 file changed, 2 insertions(+)<br><br>diff --git a/contrib/src/main.mak b/contrib/src/main.mak<br>index 0a731f11dcc..534f1d11349 100644<br>--- a/contrib/src/main.mak<br>+++ b/contrib/src/main.mak<br>@@ -70,6 +70,7 @@ endif<br> ifneq ($(findstring $(origin AR),undefined default),)<br> AR := ar<br> endif<br>+NM ?= nm<br> RANLIB ?= ranlib<br> STRIP ?= strip<br> WIDL ?= widl<br>@@ -88,6 +89,7 @@ endif<br> ifneq ($(findstring $(origin AR),undefined default),)<br> AR := $(HOST)-ar<br> endif<br>+NM ?= $(HOST)-nm<br> RANLIB ?= $(HOST)-ranlib<br> STRIP ?= $(HOST)-strip<br> WIDL ?= $(HOST)-widl<br>--<br>2.26.2<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>--<br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<br></blockquote><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>