<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hello Pascal,<br></div><div><br></div><div>No problem and thanks for your contribution. I just pushed your patch.<br></div><div><br></div><div>Best regards,<br></div><div>Thomas<br></div><div><br></div><div>On Thu, Jul 2, 2020, at 23:27, P S wrote:<br></div><blockquote type="cite" id="qt" style=""><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Hello,<br></div><div><br></div><div>Thank you all for helping me to write properly.<br></div><div>This is my very first post here and i'm not very familiar with git send-email command.<br></div><div>I did not know how to separate the subject from the explanation, I will do better next time.<br></div><div>Please accept my apology for not following the rules.<br></div><div><br></div><div>Best regards,<br></div><div><br></div><div>Pascal Souchet<br></div><div>ps: English is not my native language, you had guessed it :-)<br></div><div><br></div><div class="qt-gmail_quote"><div dir="ltr" class="qt-gmail_attr">Le jeu. 2 juil. 2020 à 22:44, Romain Vimont <<a href="mailto:rom1v@videolabs.io">rom1v@videolabs.io</a>> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>On Thu, Jul 02, 2020 at 09:12:32PM +0200, Thomas Guillem wrote:<br></div><div> > Hello,<br></div><div> > <br></div><div> > Thanks for the patch.<br></div><div> > <br></div><div> > Nitpicking, the commit title could be improved, cf. <a href="https://chris.beams.io/posts/git-commit/" rel="noreferrer" target="_blank">https://chris.beams.io/posts/git-commit/</a><br></div><div> > The title should be short, and the message should contain the explanation (if the title is not self-explanatory).<br></div><div> > <br></div><div> > I would have written:<br></div><div> > <br></div><div> > "lib: fix libvlc_media_player_get_track_from_id() always using the VIDEO count"<br></div><div> <br></div><div> Or even "lib: fix track count in get_track_from_id()" to respect the<br></div><div> 50/72 rule :)<br></div><div> <br></div><div> Regards<br></div><div> <br></div><div> > <br></div><div> > Best regards,<br></div><div> > Thomas Guillem<br></div><div> > <br></div><div> > On Thu, Jul 2, 2020, at 19:09, Romain Vimont wrote:<br></div><div> > > LGTM<br></div><div> > > <br></div><div> > > Thank you<br></div><div> > > <br></div><div> > > (ref: #24921)<br></div><div> > > <br></div><div> > > On Thu, Jul 02, 2020 at 06:32:55PM +0200, Pascal Souchet wrote:<br></div><div> > > > ---<br></div><div> > > > lib/media_player.c | 2 +-<br></div><div> > > > 1 file changed, 1 insertion(+), 1 deletion(-)<br></div><div> > > > <br></div><div> > > > diff --git a/lib/media_player.c b/lib/media_player.c<br></div><div> > > > index 2f390468c4..9c7a7a76aa 100644<br></div><div> > > > --- a/lib/media_player.c<br></div><div> > > > +++ b/lib/media_player.c<br></div><div> > > > @@ -1871,7 +1871,7 @@ x( libvlc_media_player_t *p_mi,<br></div><div> > > > for (size_t i = 0; i < ARRAY_SIZE(cats); ++i)<br></div><div> > > > {<br></div><div> > > > enum es_format_category_e cat = cats[i];<br></div><div> > > > - size_t count = vlc_player_GetTrackCount(player, VIDEO_ES);<br></div><div> > > > + size_t count = vlc_player_GetTrackCount(player, cat);<br></div><div> > > > <br></div><div> > > > for (size_t j = 0; j < count; ++j)<br></div><div> > > > {<br></div><div> > > > -- <br></div><div> > > > 2.17.1<br></div><div> > > > <br></div><div> > > > _______________________________________________<br></div><div> > > > vlc-devel mailing list<br></div><div> > > > To unsubscribe or modify your subscription options:<br></div><div> > > > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div> > > _______________________________________________<br></div><div> > > vlc-devel mailing list<br></div><div> > > To unsubscribe or modify your subscription options:<br></div><div> > > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div> > _______________________________________________<br></div><div> > vlc-devel mailing list<br></div><div> > To unsubscribe or modify your subscription options:<br></div><div> > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div></div></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div></body></html>