<html><head></head><body>Hi,<br><br>This seems wrong at least semantically. The decoder owner shouldn't give a damn about any pool that the decoder might handle internally. That's an implementation detail.<br><br>Maybe we still need a flag, though I'd rather we split the concerns at the callback level than with flags. But the name and behaviour just don't seem right in any case.<br><br><div class="gmail_quote">Le 27 juillet 2020 16:45:22 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><hr> include/vlc_codec.h | 3 +++<br> src/input/decoder.c | 2 +-<br> 2 files changed, 4 insertions(+), 1 deletion(-)<br><br>diff --git a/include/vlc_codec.h b/include/vlc_codec.h<br>index 81c2cb5d142..8ebdc111709 100644<br>--- a/include/vlc_codec.h<br>+++ b/include/vlc_codec.h<br>@@ -114,6 +114,9 @@ struct decoder_t<br> /* Tell the decoder if it is allowed to drop frames */<br> bool b_frame_drop_allowed;<br> <br>+ /* The decoder uses its own picture pool */<br>+ bool b_external_pool;<br>+<br> /**<br> * Number of extra (ie in addition to the DPB) picture buffers<br> * needed for decoding.<br>diff --git a/src/input/decoder.c b/src/input/decoder.c<br>index 99c5f12e12f..d24fa8feb34 100644<br>--- a/src/input/decoder.c<br>+++ b/src/input/decoder.c<br>@@ -428,7 +428,7 @@ static int ModuleThread_UpdateVideoFormat( decoder_t *p_dec, vlc_video_context *<br> <br> // configure the new vout<br> <br>- if ( p_owner->out_pool == NULL )<br>+ if ( p_owner->out_pool == NULL && !p_dec->b_external_pool )<br> {<br> unsigned dpb_size;<br> switch( p_dec->fmt_in.i_codec )</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>