<html><head></head><body>Hi,<br><br>Point is that control_Push() now waits for any ongoing control, even without subsequent control_Wait(). It's not a problem if we remove controls altogether eventually anyway, but there is a difference.<br><br><div class="gmail_quote">Le 17 août 2020 09:45:19 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-08-14 17:30, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le perjantaina 14. elokuuta 2020, 12.25.43 EEST Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On 2020-08-14 11:02, Thomas Guillem wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Why is it not needed anymore?<br></blockquote> I don't know why it was needed before. Maybe I'm missing something.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">vout_control_Push() will now have to wait that controls are processed.<br></blockquote>I don't see how it's different from now.<br>It needs the lock to push a command.<br></blockquote>As Thomas already pointed out, the difference is that a control request needs<br>to wait for the control queue to be unheld by vout_control_Release() before it<br>can push a control request.<br></blockquote><br>But this is not correct. The control request has this:<br><br> while (ctrl->is_held)<br> vlc_cond_wait(&ctrl->wait_available, &ctrl->lock);<br><br>It will only pop a request once the vout_control_Release() is called.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">For filter changes, the correct solution is ostensibly to take the out of the<br>vout control queue, and process them synchronously with the filter lock. They<br>won't need the display lock.<br></blockquote><br>Yes, that can be done.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Which gets back to my earlier point: it's about time to get rid of the vout<br>control queue for good. I fear that you're wasting your time trying to<br>simplify a goner.<br></blockquote><br>I'll give it a try.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>