<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Tue, Jul 21, 2020, at 01:18, Daniel Glaas wrote:<br></div><blockquote type="cite" id="qt" style=""><div>I additionally notices a bug in the generation of a scrolling title. It <br></div><div>is fixed in the update attached patch.<br></div></blockquote><div><br></div><div>Hello Daniel, your patch is doing a fix + a refactor. This makes it hard to review since your fix is hidden by your refactor.<br></div><div><br></div><div>Could you split your patch into 2 patches please? Refactor, then the fix.<br></div><div><br></div><div>Thanks in advance!<br></div><div>Thomas Guillem<br></div><div><br></div><blockquote type="cite" id="qt" style=""><div><br></div><div>Am 18.07.20 um 12:40 schrieb Daniel Glaas:<br></div><div>> You mean that instead of snprintf() the function vlc_memstream() is used?<br></div><div>><br></div><div>> Ok, it was not my purpose of this patch to replace the snprintf() <br></div><div>> calls with another functions. I just wanted to make it easier readable <br></div><div>> with function parameters are passed into snprintf(). You think that if <br></div><div>> these lines are touched, then the usage of vlc_memstream should be used?<br></div><div>><br></div><div>> Am 18.07.20 um 09:38 schrieb Rémi Denis-Courmont:<br></div><div>>> Hi,<br></div><div>>><br></div><div>>> Le lauantaina 18. heinäkuuta 2020, 5.05.14 EEST Daniel Glaas a écrit :<br></div><div>>>> Refactor RSS display string generation<br></div><div>>>><br></div><div>>>> The RSS display string generation contained lot of code <br></div><div>>>> duplications. With<br></div><div>>>> commit, structures that are used several time are factor out to make <br></div><div>>>> the<br></div><div>>>> final<br></div><div>>>> snprintf() statements which write the text into the marquee buffer <br></div><div>>>> better<br></div><div>>>> readable.<br></div><div>>> Yes but we use vlc_memstream for that sort of things nowadays. It's far<br></div><div>>> simpler and less error-prone.<br></div><div>>><br></div><div><br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div><br></div><div><b>Attachments:</b><br></div><ul><li>0002-Refactor-RSS-display-string-generation.patch<br></li></ul></blockquote><div><br></div></body></html>