<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Mon, Aug 31, 2020, at 11:45, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt" style=""><div>Hi,<br></div><div><br></div><div>I did ask if/when to apply the CLI vout settings, and explicitly noted that users had contradictory (and sometimes impossible or unrealistic) expectations in those respects.<br></div><div><br></div><div>The only opinion (not mine) was to apply them only at start. Thus I removed the trigger-callback hacks I'd previously made that did the opposite.<br></div></blockquote><div><br></div><div>I remember agreeing for this patch set. Maybe it was during a workshop and orally.<br></div><div><br></div><div>I guess it always good to write on the commit log by whom it was approved/voted. This will only help us to understand the context.<br></div><div><br></div><div>Anyway, I think we all improved our review process and commit logs/messages since then.<br></div><div><br></div><blockquote type="cite" id="qt" style=""><div><br></div><div>As far why it works for zoom and not the other two ratii, I don't know. I can only presume that I overlooked or accidentally rebased away the missing initialisation code.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 31 août 2020 12:22:39 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-k9mail"><div>On 2020-08-31 11:02, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>Before the patches were merged, here, ask the secretary and I don't like <br></div><div>your tone.<br></div></blockquote><div><br></div><div>There is no tone. It's just a basic question. Neither Thomas nor I <br></div><div>remember this vote and even less a result.<br></div><div><br></div><div>Looking at the 3 patches, they have no even been proposed for review. <br></div><div>The patches around these are all about cleaning the internals of picture <br></div><div>Aspect-ratio/Crop/Zoom/etc and are mostly OK. But removing the external <br></div><div>parameters seem to be a stretch.<br></div><div><br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>Le 31 août 2020 07:58:54 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a <br></div><div>écrit :<br></div><div><br></div><div> On 2020-08-27 16:51, Rémi Denis-Courmont wrote:<br></div><div><br></div><div> Le torstaina 27. elokuuta 2020, 13.06.32 EEST Steve Lhomme a écrit :<br></div><div><br></div><div> Not sure why these were commited.<br></div><div><br></div><div> We had a vote and decided to do that.<br></div><div><br></div><div><br></div><div> When and where was that voted and where do I see the results of that vote ?<hr> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div><br></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br></div><div>ma brièveté.<br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div></body></html>