<div dir="ltr"><div>On Wed, Sep 23, 2020 at 1:10 PM Thomas Guillem <<a href="mailto:thomas@gllm.fr">thomas@gllm.fr</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u><div><div><br></div><div><br></div><div>On Wed, Sep 23, 2020, at 08:58, Kartik Ohri wrote:<br></div><blockquote type="cite" id="gmail-m_210992530111958984qt"><div dir="ltr"><div>Hi!<br></div><div>If there are no objections, can this patchset be merged ?<br></div></div></blockquote><div><br></div><div>No, it can't be merged as it is. TODO:<br></div><div> - proper configure integration: --disable-rust/--enable-rust<br></div><div> - Decide if it's enabled or not by default<br></div><div> - Decide it rust build can break because we don't want to bother C developers to fix Rust code for now.<br></div><div> - Using cargo from system or from contrib ?<br></div><div> - CI integration<br></div><div> - Rust fmt integration<br></div><div><br></div></div></blockquote><div>Understood. +1 </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div></div><blockquote type="cite" id="gmail-m_210992530111958984qt"><div dir="ltr"><div>Thanks.<br></div><div>Regards,<br></div><div>Kartik<br></div></div><div><br></div><div><div dir="ltr">On Sun, Sep 20, 2020 at 2:39 AM Kartik Ohri <<a href="mailto:kartikohri13@gmail.com" target="_blank">kartikohri13@gmail.com</a>> wrote:<br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>This patchset aims to introduce a rust based cuesheet parsing<br></div><div> module.<br></div><div> <br></div><div> Changes since RFC v2 are as follows:<br></div><div> <br></div><div> - Added a utils module to vlccore-rs<br></div><div> This module can contain commonly used utilities for Rust<br></div><div> modules. For instance, passing Rust allocated strings to<br></div><div> C code. This is an easy thing to mess up. Rust allocated<br></div><div> pointers should not be free()`ed in C code. Hence, a<br></div><div> utility method is provided in vlccore-rs::utils to <br></div><div> ensure such issues are avoided.<br></div><div> <br></div><div> - Added cargo workspace to src and modules.<br></div><div> This will be particularly beneficial while integrating<br></div><div> rustfmt in CI and running tests for Rust modules.<br></div><div> <br></div><div> - Make the cuesheet module a mock module.<br></div><div> Since, there is already a lua based cuesheet parser<br></div><div> available in VLC and the aim of this module is to serve<br></div><div> as an example, it makes sense only to build the module<br></div><div> but not install it.<br></div><div> <br></div><div> - Use vlc_stream_Control instead of vlc_stream_vaControl<br></div><div> <br></div><div> - Other suggestions fron Code Review<br></div><div> <br></div><div> Changes left out for now:<br></div><div> <br></div><div> Since, cargo is not yet available in the CI. Adding rustfmt<br></div><div> to CI and integrating rust tests in the buildsystem has been<br></div><div> left for now. Thomas has offered to integrate cargo in the<br></div><div> CI soon. Once, that is done we can address these issues.<br></div><div> <br></div><div> Future Developments:<br></div><div> <br></div><div> John Pardo, an intern at Videolabs is working on porting the<br></div><div> vlc_input_item API to Rust. When that is done, this module<br></div><div> can almost entirely be extracted into Rust with only the<br></div><div> module declaration and setting up callabcks in C.<br></div><div> <br></div><div> [PATCH 1/2] libvlc: Add Rust API for writing modules in rust<br></div><div> [PATCH 2/2] stream filter: Add rust based cuesheet module<br></div><div> <br></div></blockquote></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div></div>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div>