<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;"><div>Ah, not a problem of not reading the manual, I think I copied and pasted the two lines below rather than typing it, and only made two of the necessary adjustments afterwards, forgetting to remove the '!'.</div><div><br></div><div>Apologies. Fixed copy attached.</div><div><br></div><div>On Mon, 2020-09-28 at 10:06 +0300, Rémi Denis-Courmont wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">Hi,<br><br>This patch is just plain wrong. RTFM.<br><br><div class="gmail_quote">Le 28 septembre 2020 02:36:27 GMT+03:00, Lyndon Brown <jnqnfe@gmail.com> a écrit :<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<pre>attached. preview:</pre><br><br><pre>From: Lyndon Brown <jnqnfe@gmail.com></pre><br><pre>Date: Sat, 30 Mar 2019 02:43:45 +0000</pre><br><pre>Subject: rootwrap: fix warning</pre><br><br><br><pre>diff --git a/bin/rootwrap.c b/bin/rootwrap.c</pre><br><pre>index 0258773b90..3de054e73a 100644</pre><br><pre>--- a/bin/rootwrap.c</pre><br><pre>+++ b/bin/rootwrap.c</pre><br><pre>@@ -248,7 +248,8 @@ int main (int argc, char *argv[])</pre><br><pre> fputs("Cannot determine unprivileged user for VLC!\n", stderr);</pre><br><pre> exit (1);</pre><br><pre> }</pre><br><pre>- setuid (uid);</pre><br><pre>+ if (!setuid (uid))</pre><br><pre>+ exit (1);</pre><br><pre> </pre><br><pre> if (!setuid (0)) /* sanity check: we cannot get root back */</pre><br><pre> exit (1);</pre><br></blockquote></div><br><pre>_______________________________________________</pre><pre>vlc-devel mailing list</pre><pre>To unsubscribe or modify your subscription options:</pre><a href="https://mailman.videolan.org/listinfo/vlc-devel"><pre>https://mailman.videolan.org/listinfo/vlc-devel</pre></a></blockquote></body></html>