<html><head></head><body>Hi,<br><br>When I manipulate the byte size of an in -memory object, or the element count of an in-memory array, I use size_t. I know then that I don't have to worry about overflow, that a reference will be size_t*, that the format string modifier is z.<br><br>I have enough other potential problems to worry about when reading or writing code.<br><br><div class="gmail_quote">Le 29 septembre 2020 22:09:48 GMT+03:00, Lyndon Brown <jnqnfe@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Tue, 2020-09-29 at 18:09 +0300, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le tiistaina 29. syyskuuta 2020, 2.56.18 EEST Lyndon Brown a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Which is exactly the current situation. With size_t, you can't<br>overflow.<br></blockquote>Who says I'd not tested it?<br></blockquote>Most error paths are not tested, or only tested once when the code is<br>first <br>written. I'm not interesting in arguing about this broadly accepted<br>notion.<br></blockquote><br>Granted.<br><br>But both changes, the size change and catching a runaway series of<br>creation requests, whichever or both you're referring to, are rather<br>trivial to understand and follow, to be confident in. I don't think<br>such concern is warranted here.<br><br>I spent a lot of time exploring the option and plugin descriptor<br>handling areas of the codebase both in terms of the Rust conversion<br>project and in terms of a bunch of work pending submission (per stuff<br>beneath it in the big patch tree gradually getting processed). This<br>isn't just a random tweak without understanding of how this stuff is<br>interacted with throughout the plugin descriptor and option handling<br>code, I've looked and understood and carefully made changes.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>