<html><head></head><body>Hi,<br><br>Shouldn't this logic be used in the Win32 GetTempPath() instead of a fixed size stack array?<br><br><div class="gmail_quote">Le 14 octobre 2020 05:53:03 GMT+03:00, Lyndon Brown <jnqnfe@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">From: Lyndon Brown <jnqnfe@gmail.com><br>Date: Fri, 9 Oct 2020 19:28:38 +0100<br>Subject: es_out_timeshift: simplify win32 case with config_GetTempPath()<br><br>this changes the functionality slightly, with the old code dynamically<br>allocating a buffer of the necessary size to hold the path, whilst the<br>config_GetTempPath() function just uses PATH_MAX. But if the implementation<br>of config_GetTempPath() using PATH_MX is inadequate, it should be changed<br>to use the model replaced here.<br><br>diff --git a/src/input/es_out_timeshift.c b/src/input/es_out_timeshift.c<br>index 8ffa1ea400..02735e807b 100644<br>--- a/src/input/es_out_timeshift.c<br>+++ b/src/input/es_out_timeshift.c<br>@@ -364,20 +364,7 @@ es_out_t *input_EsOutTimeshiftNew( input_thread_t *p_input, es_out_t *p_next_out<br> p_sys->psz_tmp_path = var_InheritString( p_input, "input-timeshift-path" );<br> #if defined (_WIN32) && !VLC_WINSTORE_APP<br> if( p_sys->psz_tmp_path == NULL )<br>- {<br>- const DWORD count = GetTempPath( 0, NULL );<br>- if( count > 0 )<br>- {<br>- WCHAR *path = vlc_alloc( count + 1, sizeof(WCHAR) );<br>- if( path != NULL )<br>- {<br>- DWORD ret = GetTempPath( count + 1, path );<br>- if( ret != 0 && ret <= count )<br>- p_sys->psz_tmp_path = FromWide( path );<br>- free( path );<br>- }<br>- }<br>- }<br>+ p_sys->psz_tmp_path = config_GetTempPath();<br> if( p_sys->psz_tmp_path == NULL )<br> {<br> wchar_t *wpath = _wgetcwd( NULL, 0 );<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>