<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>On 2020-10-14 08:11, Steve Lhomme wrote:<br>
</p>
<blockquote type="cite"
cite="mid:17cdc153-d893-4683-5ddb-b98a1231c2f5@ycbcr.xyz">On
2020-10-13 21:45, Julien Montant wrote:
<br>
<blockquote type="cite">The macro `SRTO_TSBPDDELAY` has been
deleted from SRT.
<br>
This prevents the compilation with SRT versions >= v1.4.2.
<br>
The (unrecommended) `SRTO_LATENCY` should be used instead.
<br>
</blockquote>
<br>
I don't understand. We should use it or it's not recommended ?
<br>
</blockquote>
I'm just quoting the comments of the SRC source code:<br>
<pre>SRTO_LATENCY = 23, // NOT RECOMMENDED. SET: to both SRTO_RCVLATENCY and SRTO_PEERLATENCY. GET: same as SRTO_RCVLATENCY.</pre>
<p>I'm very likely not qualified to make the proper fix, i.e. for
not using SRTO_TSBPDDELAY or SRTO_LATENCY all together. This is
just to restore compatibility with the new SRT.<br>
</p>
<blockquote type="cite"
cite="mid:17cdc153-d893-4683-5ddb-b98a1231c2f5@ycbcr.xyz">
<br>
<blockquote type="cite">See the corresponding SRT commit
0e2201aff6b379979cec43fee5e8f162717f6346.
<br>
<br>
NOTE: I was not able to find the SRT version officially
supported by VLC
<br>
on the [contrib status
wiki](<a class="moz-txt-link-freetext" href="https://wiki.videolan.org/Contrib_Status/">https://wiki.videolan.org/Contrib_Status/</a>).
<br>
The entry should probably be added.
<br>
</blockquote>
<br>
We support 1.3.0+
<a class="moz-txt-link-freetext" href="https://code.videolan.org/videolan/vlc/-/blob/master/configure.ac#L4267">https://code.videolan.org/videolan/vlc/-/blob/master/configure.ac#L4267</a>
<br>
And build 1.3.1 with a lot of patching
<br>
<a class="moz-txt-link-freetext" href="https://code.videolan.org/videolan/vlc/-/blob/master/contrib/src/srt/rules.mak#L3">https://code.videolan.org/videolan/vlc/-/blob/master/contrib/src/srt/rules.mak#L3</a>
<br>
<br>
</blockquote>
<p>OK, then the backward compatibility would not be broken by the
change of macro since SRTO_LATENCY is around since at least SRT
v.1.2.0.</p>
<p>As a user I read the wiki to check the supported version. I think
an entry should be added for SRT.<br>
</p>
<blockquote type="cite"
cite="mid:17cdc153-d893-4683-5ddb-b98a1231c2f5@ycbcr.xyz">
<blockquote type="cite">---
<br>
modules/access/srt.c | 2 +-
<br>
modules/access_output/srt.c | 2 +-
<br>
2 files changed, 2 insertions(+), 2 deletions(-)
<br>
<br>
diff --git a/modules/access/srt.c b/modules/access/srt.c
<br>
index 499a300196..d7ef51fccf 100644
<br>
--- a/modules/access/srt.c
<br>
+++ b/modules/access/srt.c
<br>
@@ -164,7 +164,7 @@ static bool srt_schedule_reconnect(stream_t
*p_stream)
<br>
/* Set latency */
<br>
srt_set_socket_option( strm_obj, SRT_PARAM_LATENCY,
p_sys->sock,
<br>
- SRTO_TSBPDDELAY, &i_latency, sizeof(i_latency)
);
<br>
+ SRTO_LATENCY, &i_latency, sizeof(i_latency) );
<br>
/* set passphrase */
<br>
if (psz_passphrase != NULL && psz_passphrase[0] !=
'\0') {
<br>
diff --git a/modules/access_output/srt.c
b/modules/access_output/srt.c
<br>
index 0b66f24a8a..3d579eb1bd 100644
<br>
--- a/modules/access_output/srt.c
<br>
+++ b/modules/access_output/srt.c
<br>
@@ -155,7 +155,7 @@ static bool
srt_schedule_reconnect(sout_access_out_t *p_access)
<br>
/* Set latency */
<br>
srt_set_socket_option( access_obj, SRT_PARAM_LATENCY,
p_sys->sock,
<br>
- SRTO_TSBPDDELAY, &i_latency, sizeof(i_latency)
);
<br>
+ SRTO_LATENCY, &i_latency, sizeof(i_latency) );
<br>
/* set passphrase */
<br>
if (psz_passphrase != NULL && psz_passphrase[0] !=
'\0') {
<br>
-- <br>
2.28.0
<br>
<br>
_______________________________________________
<br>
vlc-devel mailing list
<br>
To unsubscribe or modify your subscription options:
<br>
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>
<br>
<br>
</blockquote>
_______________________________________________
<br>
vlc-devel mailing list
<br>
To unsubscribe or modify your subscription options:
<br>
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
</blockquote>
</body>
</html>