<html><head></head><body>Ok well that just means that the pull request description is invalid, so -1 either way.<br><br><div class="gmail_quote">Le 20 octobre 2020 14:35:01 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-10-20 13:26, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Based on the description this has the exact same problems as the <br>previous version.<br><br>-1<br></blockquote><br>Not a valid code review.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 20 octobre 2020 14:04:05 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a <br>écrit :<br><br> I'm not sending the 35 patches to the ML (too big) but the individual<br> patches can be found at<br> <a href="https://code.videolan.org/robUx4/vlc/-/tree/filters/refactor-ops/13">https://code.videolan.org/robUx4/vlc/-/tree/filters/refactor-ops/13</a><br><br> Changes since v2:<br> - rebased on master + epileptic filter support + picture dropping filters<br> - "full" draining of filters is supported in the vout, transcode,<br> mosaic, SDI<br> - a flag to the drain callback of filters is added to tell them they<br> should not only sending the delayed pictures they may have left to send<br> but also anything else based on the source pictures they were given. No<br> more pictures will be given until a flush or a deletion of the filters.<br> - for now no filters give extra pictures, this is left to implement per<br> filter, in addition of the drain callback they already have<br> - the filter chain doesn't store "pending" pictures anymore. When a<br> filter_chain_VideoFilter() is done without (enough) draining before, it<br> starts draining all filters first. This is how the filter chain worked<br> so far. They were stored in pending and if nothing drying the pending<br> chain, they were released in the next filter_chain_VideoFilter() call.<br><br> Changes since v1:<br> - fix misc compilation issues<br> - rework the fps code so that the extra pictures can actually be added<br> - rework the fps draining with more explanation. Using the<br> p_sys->p_previous_pic->date<br> was incorrect as it was shifted already.<br> - keep the reference date for VDPAU x2 deinterlacing draining<br> - add truncated commit text in last patch<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>