<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 11.11.2020 um 18:59 schrieb Marvin Scholz <<a href="mailto:epirat07@gmail.com" class="">epirat07@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On 11 Nov 2020, at 18:57, Zhao Zhili wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">> On Nov 12, 2020, at 1:50 AM, Marvin Scholz <<a href="mailto:epirat07@gmail.com" class="">epirat07@gmail.com</a>> wrote:<br class=""><blockquote type="cite" class=""><br class=""><br class=""><br class="">On 11 Nov 2020, at 17:44, Felix Paul Kühne wrote:<br class=""><br class=""><blockquote type="cite" class="">Hello,<br class=""><br class=""><blockquote type="cite" class="">Am 10.11.2020 um 16:30 schrieb Zhao Zhili <<a href="mailto:quinkblack@foxmail.com" class="">quinkblack@foxmail.com</a>>:<br class=""><br class="">---<br class="">extras/package/macosx/build.sh | 2 +-<br class="">1 file changed, 1 insertion(+), 1 deletion(-)<br class=""><br class="">diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh<br class="">index 4508354a9f..be5d449662 100755<br class="">--- a/extras/package/macosx/build.sh<br class="">+++ b/extras/package/macosx/build.sh<br class="">@@ -10,7 +10,7 @@ info()<br class=""><br class="">ARCH="x86_64"<br class="">MINIMAL_OSX_VERSION="10.7"<br class="">-OSX_VERSION=`xcrun --show-sdk-version`<br class="">+OSX_VERSION=`xcrun --show-sdk-version |cut -d. -f1-2`<br class="">OSX_KERNELVERSION=`uname -r | cut -d. -f1`<br class="">SDKROOT=`xcode-select -print-path`/Platforms/MacOSX.platform/Developer/SDKs/MacOSX$OSX_VERSION.sdk<br class="">VLCBUILDDIR=""<br class="">—<br class="">2.28.0<br class=""></blockquote><br class=""><br class="">LGTM and needs backport to 3.0.<br class=""><br class=""></blockquote><br class="">LGTM from my side too, but shouldn't this be using xcrun --show-sdk-path<br class="">which seems much better approach than to try to manually put together a SDK path…<br class=""></blockquote><br class="">I'm not familiar about the build environment of macOS. Fill free to fix it cleanly<br class="">with a better approach.<br class=""><br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Sure, I was not expecting you to fix this, just wanted to propose this and get opinions</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">from Felix and maybe David who are more familiar with the build.sh script.</span></div></blockquote><br class=""></div><div>Yes, we are already using "xcrun --show-sdk-path“ in the master repo, this patch and the problem should be only there in 3.x.</div><div>For some reason, in 3.x OSX_VERSION environment variable is also still used and exported in the contrib system (not sure why, though).</div><div><br class=""></div><div>We could backport the environment we have in vlc.git also to 3.x, but if we want to, maybe lets do it after the pending release.</div><div><br class=""></div><div>BR. David</div><div><br class=""></div><div><br class=""></div><div><br class=""></div></body></html>