<html><head></head><body>Hi,<br><br>1) I have yet to see any outrageous actions.<br>2) My will to take responsibility for something is my prerogative. I think it is normal considering that I asked for that thing in the first place. I don't understand and I don't really care why you have a problem with it.<br>3) You have all but refused to revert considering your statements in response to my revert requests.<br>4) It was supposed to happen because you violated the review rules.<br><br>Now I'm surprised that there was no message in vlc-commits and #videolan if somebody indeed force-pushed. IIRC, that used to happen, and you'd know who did it from the commiter field.<br><br>Now I'm left assuming somebody did it because I asked, and it makes sense for me to take responsibility then. Or maybr it was just a mismanipulation from me or someone else.<br><br><div class="gmail_quote">Le 17 novembre 2020 13:49:58 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-11-17 12:31, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>Considering that I asked to revert, there was notice. You can argue <br>semantics whether that's quite a notice or not. You can argue thay <br>revert and removal are different (though I think removal is better where <br>possible). And as I said, I will take responsibility for both of those <br>inconsistencies.<br></blockquote><br>You shouldn't take responsibility for someone else's outrageous actions.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">But you're being contradictory. Steve has refused to revert. Can't <br></blockquote><br>I never refused it. I never even had the time to do it. I only noticed <br>the commits where gone when Romain mentioned it on Monday.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">exactly blame a revert that was supposed to happen. This is just <br></blockquote><br>How can you come to the conclusion it was supposed to happen. You don't <br>decide for everyone else, starting with me. At the very least it should <br>have been discussed. And we did continue the discussion on the patches. <br>I have no problem with that.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">diverting attention from the real issue of a certain developer's <br>attitude to code review.<br><br><br>(And I don't think I ever ignored code review on core since it's been <br>made mandatory. I specifically went through code review for all the core <br>parts of the YT-DL work.)<br><br>Le 17 novembre 2020 13:18:37 GMT+02:00, Thomas Guillem <thomas@gllm.fr> <br>a écrit :<br><br><br><br> On Tue, Nov 17, 2020, at 12:01, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Those patches had no rights to merged and I correctly asked for<br>them to be removed.<br></blockquote> It already happened in the past: problem of communication, leading<br> to patch that is pushed but should not have to. This is not a CoC<br> violation, it's a developing error / ML incomprehension. When it<br> happens, we generally ask for a revert and the developer generally<br> fix his commits or revert them. There is no need to push force when<br> that situation occurs.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Thanks to whomever did it.<br><br> I find your false accusations of outrageous and in violation of<br> the CoC. The one who violated the rules is Steve.<br></blockquote> Which accusations are outrageous? I don't think I accused anyone.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> And then he insulted me on top.<br><br> Le 17 novembre 2020 12:00:49 GMT+02:00, Thomas Guillem<br> <thomas@gllm.fr> a écrit :<br><br> Ping.<br><br> Somebody push --forced without notifying us on the ML. This is<br> a CoC violation or a security issue.<br><br> <a href="https://wiki.videolan.org/Code_of_Conduct/">https://wiki.videolan.org/Code_of_Conduct/</a><br> <<a href="https://wiki.videolan.org/Code_of_Conduct/">https://wiki.videolan.org/Code_of_Conduct/</a>><br> "Do NOT delete another developer's commit without approval by<br> using push --force."<br><br> On Mon, Nov 16, 2020, at 11:10, Romain Vimont wrote:<br><br> Hi,<br><br> When I git-pulled this morning, it refused:<br><br> fatal: Not possible to fast-forward, aborting.<br><br> Some commits I retrieved previously have been removed from<br> the master<br> branch:<br><br> $ git log --oneline origin/master..master<br> e326d846bf (master) decoder: make sure decoder updates use<br> enough<br> output pictures<br> 270d501bf3 video_output: change the deinterlacing filter<br> before<br> displaying the picture<br> 9591771a6b video_output: allow changing the interlacing<br> mode while<br> locked<br> 3d0e4ebb14 video_output: get rid of the internal<br> "deinterlace-needed" variable<br> 05acaa1e45 video_output: let the deinterlacing code access<br> vout_thread_interlacing_t<br> ebbbdf7d83 video_output: use a separate structure for the<br> deinterlacing state<br> 14588c7d06 video_output: change the filters before<br> checking for<br> late frames<br> d4c036a5f3 video_output: allow flushing filters without<br> flusing the<br> displayed.current<br> 3d13aad3b4 video_output: keep the displayed.current in<br> frame by<br> frame if next is not ready<br> b7503cbfec video_output: move up a test on NULL<br> displayed.current<br> 42011517f3 video_output: don't use displayed.next in frame<br> by frame<br> mode<br> 9eb231ed0d libvlc: set a name on the medialist seek thread<br> d6f0a4215a modules: set names to threads created in modules<br> 2415cec16a core: set names to threads created in the core<br> 5bc16beec1 thread: add a function to give names to threads<br><br> Was it on purpose?<br><br> Regards<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br> <<a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br> <<a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>><br><br><br> -- <br> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez<br> excuser ma brièveté.<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br> <<a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>><br></blockquote><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>