<html><head></head><body>No, I replaced an antilogy with an assertion.<br><br><div class="gmail_quote">Le 4 décembre 2020 08:57:58 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2020-12-03 18:54, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le torstaina 3. joulukuuta 2020, 19.36.58 EET Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On 2020-12-03 17:29, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Le torstaina 3. joulukuuta 2020, 11.14.49 EET Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">p_sys->csa in ts.c can be NULL (see csaSetup()) and the ts code will<br>work fine. So the NULL case is very much used (and I believe the common<br>case).<br></blockquote>I don't know what code base you are referring to. csa_UseKey() has a<br>single<br>call site in vlc.git and that's the one getting patched here.<br></blockquote>p_sys->csa in ts.c can still be NULL.<br></blockquote>So what?<br></blockquote><br>So you just replaced a NULL check (that happens 99.9% of the time) by an <br>assert that will crash all 99.9% of the time (either in the assert of <br>the NULL de-reference).<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>