<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>MSCV is a recent compiler, and we should support it (lot of open-source projects support mingw and msvc).<br></div><div><br></div><div>Some other projects tend to remove VLA usage : <a href="https://www.phoronix.com/scan.php?page=news_item&px=Linux-Kills-The-VLA">https://www.phoronix.com/scan.php?page=news_item&px=Linux-Kills-The-VLA</a><br></div><div><br></div><div>We need to decide what to do about your VLA, specially since we can go back (there are not that many VLA in VLC for now).<br></div><div><br></div><div>On Wed, Dec 9, 2020, at 10:31, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt" style=""><div>VLA are required just like hosting and threads and atomics are required. By VLC, and in the case of VLAs also by C99.<br></div><div><br></div><div>None of those are required by C11 and that's completely irrelevant, as VLC is not meant to run on bare metal or historical ISAs.<br></div><div><br></div><div><br></div><div class="qt-gmail_quote"><div>Le 9 décembre 2020 11:25:50 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo@beauzee.fr> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-k9mail"><div>On Wed, Dec 9, 2020, at 10:20 AM, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>No it is not fine as already explained and as is obvious from reading <br></div><div>most call sites.<br></div><div><br></div><div>-1<br></div></blockquote><div><br></div><div>AFAICS all callsites except lua handle the error explicitly. Lua forwards the fd to its own caller which is responsible for checking the return value as can be expected.<br></div><div>I don't understand why an additional error case is so problematic.<br></div><div>Also, as for the other patches, this can't be expected to compile everywhere, since VLA are not mandatory.<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div></body></html>