<html><head></head><body>Hi,<br><br>If the user requested crop in pixel values, we should obey. We're talking about a command line option here. It does not apply to just the first encountered video format. That's literally the only reason why we distinguish window and border crop...<br><br>If the user wants a crop ratio, then they should specify a ratio. That's what happens if they use the GUI menu or the C hotkey.<br><br>We could a crop (centered) zoom mode if we want to crop proportionally in both dimensions. But I have never seen a request for that, so it sounds like a pure for-the-sake-completeness academic exercise.<br><br><div class="gmail_quote">Le 8 février 2021 12:52:33 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2021-02-08 11:49, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le maanantaina 8. helmikuuta 2021, 9.58.58 EET Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">If the code is next called with vout_UpdateDisplaySourceProperties()<br>osys->crop.left (and the others) will be 0. This effectively resets a<br>previous call to vout_SetDisplayCrop(). I don't know if it's intentional<br>or not.<br></blockquote>I tihnk it's left-over from the old vout display management loop and its error<br>handling.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">I don't think there's a good way to handle this case: the user<br>set a manual crop on certain video dimension and then the video<br>dimension changes.<br></blockquote>That's the FIXME that this patch fixes and removes: We need to keep track of<br>the _crop mode_, so that the effective crop window can be recomputed in<br>accordance with user settings even if the source format changes.<br></blockquote><br>So if I have a 1280x720 video on which I crop 500 pixels on the left, if <br>the dimension changes to 640x480 I still crop 500 pixels ?<br>It may not what the user expects. It may be better to apply a factor to <br>the crop.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>