<!DOCTYPE html><html><head><title></title><style type="text/css">
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hello Sergio,<br></div><div><br></div><div>I sent few comments on your merge request, otherwise it looks good to me.<br></div><div><br></div><div>Could you send all your patches to the mailing list (after fixing my comments) for the merge to happen?<br></div><div><br></div><div>Best,<br></div><div>Thomas Guillem<br></div><div><br></div><div>On Fri, Mar 19, 2021, at 16:59, Sergio M. Ammirata, Ph.D. wrote:<br></div><blockquote type="cite" id="qt" style="text-align:left;direction:ltr;"><div>Hello Thomas,<br></div><div><br></div><div>I have done as you suggested.<br></div><div><br></div><div>I forked the VLC repo and created a branch called librist in my fork. In that branch, I removed the old rist modules and replaced them with the new librist based ones (separate commits) with backward compatible config options. I also added the librist library to the contrib section.<br></div><div><br></div><div>Then, I created a merge request and verified that librist and the VLC rist modules both compiled properly in all 18 architectures.<br></div><div><br></div><div>Here is a link to the branch where you can see the 6 commits: <a href="https://code.videolan.org/sammirata/vlc/-/tree/librist">https://code.videolan.org/sammirata/vlc/-/tree/librist</a><br></div><div><br></div><div>Here is the merge request: <a href="https://code.videolan.org/sammirata/vlc/-/merge_requests/1">https://code.videolan.org/sammirata/vlc/-/merge_requests/1</a><br></div><div>Here are the successful results of the compilation on all the OSes: <a href="https://code.videolan.org/sammirata/vlc/-/pipelines/79549">https://code.videolan.org/sammirata/vlc/-/pipelines/79549</a><br></div><div><br></div><div>Because librist only support mbedtls which it is not part of the contribs and does not seem to be an easy addition (I tried), for now, I am compiling it without external encryption library support which means two things:<br></div><div>1) For any architecture except linux, AES will be software only (no hardware acceleration).<br></div><div>2) The library will not have support for SRP authentication.<br></div><div><br></div><div>We plan to add support for gnutls at a later date and then turn those extra features on.<br></div><div><br></div><div>If there is anything else needed for the merge to happen, please let me know.<br></div><div><br></div><div>Regards,<br></div><div><br></div><div>Sergio<br></div><div><br></div><div>On Wed, 2021-02-03 at 10:12 +0100, Thomas Guillem wrote:<br></div><blockquote type="cite" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div>Hello,<br></div><div><br></div><div>it's hard to review a .patch file.<br></div><div><br></div><div>Please send your patch inline or send a link to a gitlab/github MR/branch.<br></div><div><br></div><div>I would really prefer if we remove the old one when adding this new one. If you are not sure libRIST is built on all platforms supported by VLC, just do a merge request to your own repo, with contrib librist, and the librist module in order to trigger the CI. That way, we will know which platforms need fixes.<br></div><div><br></div><div>On Wed, Feb 3, 2021, at 02:43, Sergio M. Ammirata, Ph.D. wrote:<br></div><blockquote type="cite" id="qt-qt" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div>Any feedback?<br></div><div><br></div><div>On Thu, 2021-01-14 at 22:22 -0500, Sergio M. Ammirata, Ph.D. wrote:<br></div><blockquote type="cite" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div><br></div><div>Here is a revised patch with compatible config settings (all items below fixed). I also reduced the number of settings to the minimum required.<br></div><div><br></div><div>Regards,<br></div><div><br></div><div>Sergio<br></div><div><br></div><div>On Sun, 2020-12-27 at 16:39 +0100, Jean-Baptiste Kempf wrote:<br></div><blockquote type="cite" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div>On Sun, 27 Dec 2020, at 14:15, Sergio M. Ammirata, Ph.D. wrote:<br></div><blockquote type="cite" id="qt-qt-qt" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div>The config options do not match 100% either. Here is the analysis on the config options:<br></div><div>1) The config for the buffer size is called "latency" on native rist and "buffer" in the librist module.<br></div></blockquote><div><br></div><div>Fix this.<br></div><div><br></div><blockquote type="cite" id="qt-qt-qt" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div>2) There are a few config options present in native rist that do not exist on the librist module (packet-size, maximum-jitter, nack-type, disable-nacks, mcast-blind-nacks).<br></div></blockquote><div><br></div><div>Fix this.<br></div><div><br></div><blockquote type="cite" id="qt-qt-qt" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:2px;padding-left:1ex;"><div>3) There are a number of new config options present in librist module that do not exist in native rist. These are expected as the new settings/options are related to encryption, selecting profile levels, multiplexing, multipath, congestion control and timing mode.<br></div></blockquote><div><br></div><div>Remove the unneeded ones. We have too many already.<br></div><div><br></div><div>Best,<br></div><div><br></div><div id="qt-qt-sig60240713"><div class="qt-qt-signature">--<br></div><div class="qt-qt-signature">Jean-Baptiste Kempf - President<br></div><div class="qt-qt-signature">+33 672 704 734<br></div><div class="qt-qt-signature"> <br></div><div class="qt-qt-signature"><br></div></div><div><br></div></blockquote><pre>_______________________________________________<br></pre><pre>vlc-devel mailing list<br></pre><pre>To unsubscribe or modify your subscription options:<br></pre><pre><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div><pre>_______________________________________________<br></pre><pre>vlc-devel mailing list<br></pre><pre>To unsubscribe or modify your subscription options:<br></pre><pre><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div></body></html>