<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Ah yes, the default type should be audio. This will restore the VLC 2.2 behavior.<br></div><div><br></div><div>On Tue, Mar 30, 2021, at 08:55, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt" style=""><div>Hi,<br></div><div><br></div><div>I don't think that's right. You're just moving the problem from subs to audio and introducing a regression while doing so.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 29 mars 2021 18:51:01 GMT+03:00, Alaric Senat <dev.asenat@posteo.net> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-k9mail"><div>Since c34d719f, all files passed by the option `input-slave` were set as<br></div><div>audio tracks no matter what.<br></div><div>This commit attempts to deduce the `input-slave` type with its file<br></div><div>extension and falls back to spu in case of failure.<br></div><div><br></div><div>Fixes #25549<hr> src/input/input.c | 11 ++++++++++-<br></div><div> 1 file changed, 10 insertions(+), 1 deletion(-)<br></div><div><br></div><div>diff --git a/src/input/input.c b/src/input/input.c<br></div><div>index ea64473a0b..aa8280e7b9 100644<br></div><div>--- a/src/input/input.c<br></div><div>+++ b/src/input/input.c<br></div><div>@@ -984,8 +984,17 @@ static void GetVarSlaves( input_thread_t *p_input,<br></div><div> if( uri == NULL )<br></div><div> continue;<br></div><div> <br></div><div>+ enum slave_type i_type;<br></div><div>+ if ( !input_item_slave_GetType(uri, &i_type) )<br></div><div>+ {<br></div><div>+ msg_Warn( p_input,<br></div><div>+ "Can't deduce slave type of `%s\": falling back to spu.",<br></div><div>+ uri );<br></div><div>+ i_type = SLAVE_TYPE_SPU;<br></div><div>+ }<br></div><div> input_item_slave_t *p_slave =<br></div><div>- input_item_slave_New( uri, SLAVE_TYPE_AUDIO, SLAVE_PRIORITY_USER );<br></div><div>+ input_item_slave_New( uri, i_type, SLAVE_PRIORITY_USER );<br></div><div>+<br></div><div> free( uri );<br></div><div> <br></div><div> if( unlikely( p_slave == NULL ) )<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div></body></html>