[x264-devel] add optimised functions (hpel_filter, ssd, ssim)

[Guillaume POIRIER]

Hello,

On Nov 18, 2007 5:21 AM, Noboru Asai <noboru.asai at gmail.com> wrote:
> Hi,
>
> These patches add the following optimised functions accelerated with
> altivec.
>
> o x264_hpel_filter_altivec()

I tested and bencharked them, good job!
Overall, I'm getting a 10-11% fps boost, with default encoding
settings. That's really good.

Committed.


> o pixel_ssd_8x8_altivec()

As far as this once is concerned, I seem to be too sleepy to find a
set of command-line options that trigger this usage. Would you have
one that I could use for testing?

Not committed.



> o ssim_4x4x2_core_altivec()

This one is committed too. I'm curious though: in which case (I mean,
with which set of encoding option) is this one used sufficiently
enough to be high in the profiling chart?


Nice job Noboru Asai, thanks for your work!

BTW, If you're looking for some more stuff to optimize, maybe you
could have a look at the macro
ALTIVEC_STORE_SUM_CLIP: the 2 known cases where this macro is used is
with 8-byte aligned memory or 16-bytes aligned memory, so it should be
possible to write a specialized version for these two cases, that
would be a bit faster.

This has been discussed already in the thread:
http://www.via.ecp.fr/via/ml/x264-devel/2006-09/msg00068.html

Guillaume
--
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte