[x264-devel] commit: Add optional more optimal B-frame decision method ( Jason Garrett-Glaser )

[Jason Garrett-Glaser]

On Mon, Sep 15, 2008 at 11:47 AM, Dave Brueck <x264list at protoven.com> wrote:
> On Sep 14, 2008, at 10:24 PM, git version control wrote:
>
>> Add optional more optimal B-frame decision method
>> This method (--b-adapt 2) uses a Viterbi algorithm somewhat similar
>> to that used in trellis quantization.
> [snip]
>> This patch also reads b_adapt and scenecut settings from the first
>> pass so that the x264 header information in the output file will
>> have correct information (since frametype decision is only done on
>> the first pass).
> [snip]
>>
>> Diff:   http://git.videolan.org/gitweb.cgi/x264.git/?a=commitdiff;h=9818865c1f5eccbc04fb51f062cb1b3abff02db0
>
> I've been trying the above patch and now get "x264_encoder_open
> failed" errors when encoding content without b-frames. Is it possible
> that b-frames are now accidentally "required" for multi-pass encodes
> due to the following?

You're right.  Fix incoming.

Dark Shikari