[x264-devel] Patch: C89 compatibility for msvc

[Martin Storsjö]

On Mon, 24 Mar 2014, Jean-Baptiste Kempf wrote:

> On 19 Mar, Steven Walters wrote :
>> On Wed, Mar 19, 2014 at 7:06 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:
>>
>>> On 13 Mar, Matt Oliver wrote :
>>>> OK here is an even simpler updated patch that fixes both libx264 and the
>>>> x2645cli compilation so that it can be performed natively using MSVC.
>>>> Tested using Visual Studio 2013 and also tested using gcc 4.8.2 to ensure
>>>> nothing was affected in any other build chains. From the patch though you
>>>> can see that the changes are so small that this was unlikly.
>>>
>>> Adding {} around return is a bit ridiculous. This is a known VS 2013
>>> bug. Please update to update 2 CTP.
>>>
>>
>> Is there a known timeline for when 2013 update 2 will become RTM?
>> I feel like supporting unfinalized patches/updates do not amount to much
>> benefit.
>
> Less that one month. Expect it in 2 weeks, though (//BUILD).

In practice it seem to have taken a bit longer than this, but now final 
MSVC 2013 Update 2 is out. One bug still is present that affects x264 
(https://connect.microsoft.com/VisualStudio/feedback/details/808469) that 
hasn't been fixed in this release.

// Martin