[x264-devel] [Git][videolan/x264][master] configure: Always make shared imply PIC

[Anton Mitrofanov (@BugMaster)]

Anton Mitrofanov pushed to branch master at VideoLAN / x264


Commits:
19856cc4 by Jessica Clarke at 2021-12-30T20:10:51+00:00
configure: Always make shared imply PIC

Building a shared library without -fPIC does not make sense. On most
architectures, especially recent ones, doing so will give link-time
errors due to relocations in read-only sections like .text. On some
legacy architectures, including i386, it is allowed by default, but will
warn, and is highly discouraged due to the overheads it adds at library
load time. Most architectures were already listed here as having shared
imply PIC, but not all, such as i386 which ends up with unwanted text
relocations, as well as architectures not known to the build system
currently like RISC-V, which does not permit text relocations by
default. There is no good reason to want shared without PIC on any
architecture, so just remove the architecture list.
- - - - -


1 changed file:

- configure


Changes:

=====================================
configure
=====================================
@@ -921,7 +921,7 @@ if [ $compiler_style = GNU ]; then
     fi
 fi
 
-if [ $shared = yes -a \( $ARCH = "X86_64" -o $ARCH = "PPC" -o $ARCH = "ALPHA" -o $ARCH = "ARM" -o $ARCH = "IA64" -o $ARCH = "PARISC" -o $ARCH = "MIPS" -o $ARCH = "AARCH64" \) ] ; then
+if [ $shared = yes ] ; then
     pic="yes"
 fi
 



View it on GitLab: https://code.videolan.org/videolan/x264/-/commit/19856cc41ad11e434549fb3cc6a019e645ce1efe

-- 
View it on GitLab: https://code.videolan.org/videolan/x264/-/commit/19856cc41ad11e434549fb3cc6a019e645ce1efe
You're receiving this email because of your account on code.videolan.org.