Cool. I'll apply it as soon as I get back to my powerbook.<br><br>One thing though: I think this speaks more to the penetration of x264 with linux ppc users, rather than the linux community as a whole. Case in point: Cinelerra, a project I expect x264 developers have at least heard of, (
<a href="http://cvs.cinelerra.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">cvs.cinelerra.org</a>), has been looking for an altivec maintainer for at least a year now (I think). I finally got enough time to offer my services, and I hope to make some contribution there, but I bet part of the issue is: mac videophiles have a lot of alternatives in os x, such as Imovie HD (or more probably a pirated FinalCutStudio) , Handbrake, and FFmpegX, and if they want to use fink or darwinports they can get some of the straight linux stuff without dualbooting.
<br><br>Anyway, I'll get back to you when I can about the patch, and thanks again,<br><br>-griff<br><br><div><span class="gmail_quote">On 1/22/07, <b class="gmail_sendername">Guillaume POIRIER</b> <<a href="mailto:poirierg@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
poirierg@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi,<br><br>On 1/21/07, Griffith Rees <<a href="mailto:griff.rees@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
griff.rees@gmail.com</a>> wrote:<br>> Well, I don't know what else to say than thank you, and please let me know<br>> if there's any more help I can provide.<br><br>Attached patch should allow you to go further in compilation process,
<br>but since I haven't addressed all issues yet, it won't completely<br>compile.<br><br>If all goes "well", you should terminate compilation with this error<br>(which is normal):<br><br>gcc-4.1.1 -O4 -ffast-math -Wall -I. -D__X264__ -DHAVE_MALLOC_H
<br>-maltivec -mabi=altivec -DARCH_PPC -DSYS_LINUX -DHAVE_PTHREAD -s<br>-fomit-frame-pointer -c -o common/ppc/dct.o common/ppc/dct.c<br>common/ppc/dct.c: In function 'x264_add8x8_idct8_altivec':<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:348: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:349: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:350: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:351: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:352: error: invalid parameter combination for AltiVec intrinsic
<br>common/ppc/dct.c:353: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:354: error: invalid parameter combination for AltiVec intrinsic<br>common/ppc/dct.c:355: error: invalid parameter combination for AltiVec intrinsic
<br>make: *** [common/ppc/dct.o] Error 1<br><br>I'm mainly posting this patch to know if such patch meets x264's<br>quality standards.<br>I think it's ok, but I prefer to ask.<br><br>BTW, this bug report clearly shows that x264's user base on Linux is
<br>very, very thin as this code has been on x264's svn for several weeks.<br><br><br>Guillaume<br><br><br></blockquote></div><br>